[JIT] Unit test for torch script about kornia

[edgarriba]

@Wizaron cool that you want to go ahead with this ! there's one thing that I'm not quite sure yet - I see to many assertions, and usually that's an anti-pattern for test design :D

I would go for something more modular by provding proper test classes to cover the different needs.

Maybe @carlosb1 could give us an intuition to proceed with this since he's working on the mypy test integration.

[carlosb1]

Some ideas to discuss. First, It is added an assert for "case" to test, for this reason it should be a bad design has multiple asserts in a test.. it is better split for every case. Also, it would be good to split tests that they are testing feature / functionality or if it is checking the function (unitary test). For this last case, we can split them in different files, and when the set of number of tests increase too much, It would be move directly to different folders. One idea could be move tests in three main types: stress or system tests (to check performance), functional tests (to check functionality and to analyse if the functions are working well) and finally unitary tests (to check outputs for each function).

[edgarriba]

@Wizaron could you investigate this ? #45
@carlosb1 could you share the snippet for testing you mention ?

[edgarriba]

@Wizaron @carlosb1 In my last two PR I've been adopting this pattern for test. Let me know your thoughts about how you can adapt it to JIT and others.

https://github.com/arraiyopensource/torchgeometry/blob/master/test/test_transformations.py#L11

[carlosb1]

@edgarriba @Wizaron . From my side, it seems enough, I was checking different options for splitting the test and I couldn't find anything better.

[edgarriba]

unit tests with JIT are already included in latest cointributions, check: https://github.com/arraiyopensource/kornia/blob/master/test/filters/test_filters.py#L52

closing this.