Coder Social home page Coder Social logo

Comments (7)

kornelski avatar kornelski commented on June 24, 2024 1

I've added only for dependencies. For other field it's going to be rough, because it makes struct access pretty ugly. I'm not sure how to implement it.

from cargo-deb.

kornelski avatar kornelski commented on June 24, 2024 1

cargo metadata, ironically, doesn't include package's metadata field required for cargo-deb.

from cargo-deb.

kornelski avatar kornelski commented on June 24, 2024 1

Done

from cargo-deb.

kornelski avatar kornelski commented on June 24, 2024 1

Published

from cargo-deb.

benferse avatar benferse commented on June 24, 2024

Pretty sure this is in progress. I think @kornelski made the changes required in cargo_toml 0.12.x

from cargo-deb.

domenicquirl avatar domenicquirl commented on June 24, 2024

@kornelski do you mean here or in cargo_toml? I haven't looked into it too much, but I expected cargo_toml to mostly implement the Cargo.toml data model.

For other tooling, a lot of which currently faces similar issues, an alternative solution that was suggested is building on cargo metadata instead. I've mostly heard about that in the context of things like cargo outdated or cargo udeps, which currently use cargo as a library (and have not integrated a new version which supports workspace inheritance yet), but maybe it applies here as well. Potential benefits could be

  • the result of running cargo metadata is more synced up with the locally installed toolchain. In particular, updating cargo through the toolchain makes new features available independently of the currently installed version of third-party tools and the library versions they are currently using in their dependencies (the local version may also lag behind, in which case the user is unable to use new features regardless).
  • the data returned by cargo metadata is already somewhat aggregated, e.g. inherited data is inlined into the respective packages. The metadata format is therefore more stable than individual file formats.

from cargo-deb.

domenicquirl avatar domenicquirl commented on June 24, 2024

Hey @kornelski, thanks a lot for picking this up so quickly! πŸŽ‰

Do you think you could release a patch that includes #53? I've just been bitten by edition after coming back to this. We've excluded it from inheritance for now so we're able to inherit dependencies and the other metadata. That is working well now with 1.40.3, but since it seems that the issues with edition and readme are already fixed it would be even better if we could have a version with the patch applied that "just works".

Thanks again for your work in maintaining cargo deb - it's great! ☺️

from cargo-deb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.