Comments (16)
@immoh are you in charge? I probably still have commit rights, but would love to get feedback on this quick branch I hacked up pretty fast.
from korma.
@AlexBaranosky I am still in charge but there hasn't been much activity on Korma lately (latest release is almost 1 year ago).
This seems like something that could be useful to other people so I am ok with taking it in.
from korma.
@immoh any considerations about the fn name add-comment
or anything in the implementation? Then I can PR it.
from korma.
@AlexBaranosky Implementation looks good, name is fine too.
from korma.
from korma.
hmmm let me fix that... I guess there was a big change between my branch and master where I rebased it... or maybe I just screwed up the rebase :)
from korma.
fixed, and merged #380
from korma.
@immoh what's the process for doing a Korma release... I forget, it's been a while. Is it documented at all?
git diff master v0.4.3
is not a small amount of changes. Maybe it's time to release 0.4.4
?
from korma.
I gave Chris a ping on Twitter to ask about release processes. I agree that we should have an 0.4.4
release soon; it's rarely a good idea to accumulate too many commits between releases.
from korma.
I was supposed to reply to this long time ago but somehow it slipped my mind. I have been doing releases in the following way:
- Create a commit that contains:
- Version update in project.clj from (0.4.4-SNAPSHOT to 0.4.4)
- Version update in README.md
- Generated Codox docs
- Release notes in HISTORY.md
- Deploy new jar to Clojars (
lein deploy clojars
?) - Tag commit with v0.4.4
- Create a new commit in gh-pages branch that updates the docs (visible in http://korma.github.io/Korma/)
However, thereโs a problem with current master that it may not be in a releasable state even though tests are passing. There were some pretty big changes in master there were not 100% completed and I made release v0.4.3 from separate branch where I cherry-picked some changes from master. Remaining work for 0.5.0 was tracked here: https://github.com/korma/Korma/milestone/2. This work needs to be completed.
Another option would be to revert all changes from master that have been done before v0.4.3 release but are not included in the release.
from korma.
Ah. Hm.
I don't love the idea of having master being unclean or deviant from the actual releases. I'm not sure what the right approach should be here. My naive suggestion would be that we just mark master head as a release candidate for 0.5.0 and release it as 0.5.0-rc1 and try to get feedback from the community about whether anything breaks for them. That gives us a bit of room to address issues and will increase our confidence about being able to release 0.5.0 safely.
#313 is the only issue currently blocking on the 0.5.0 milestone - is that an absolutely necessary issue for the release?
from korma.
Yes, definitely a bad decision on my side to have master unclean.
I cannot remember all the details as it has been a while since I worked on Korma. I looked at the closed issue in the milestone and the big change in 0.5.0 is removal of global options (breaking change). This can cause wrong delimiters being used in certain situations and #313 is about this. It is hard to say if it's absolutely necessary. I think cutting a release candidate and getting feedback from the community sounds like a reasonable approach.
from korma.
I don't think I have release rights in Clojars - do you might actually cutting the release? I'm happy to handle messaging to Clojurians, the Clojure/Korma Google groups, etc.
from korma.
Sure, I will try to find time to do it later today.
@AlexBaranosky you are also admin of Clojars korma group - could you add @venantius to the group?
from korma.
0.5.0-RC1 is now published to Clojars. I didn't change version in README, probably it makes sense to mention both last stable version and release candidate versions.
from korma.
I've now sent the email to the Clojure google group, the Korma google group, and Clojurians.
from korma.
Related Issues (20)
- Any way to specify ON CONFLICT DO NOTHING? HOT 2
- Empty "SET" in Update HOT 2
- No default connection pool when using defdb HOT 1
- 0.4.3 issue which may be simple to solve but has me mystified. HOT 2
- [enhancement] Updating a row should respect `jdbc/ISQLParameter` and `jdbc/ISQLValue` protocols
- Maintainers Wanted HOT 2
- http://sqlkorma.com/docs is down HOT 3
- clojure korma.core order ้ฎ้ข HOT 2
- Do has-many relations not work with (fields :otherthan*)?
- Aliasing entities in (with ..)
- Missing REPLACE or UPSERT and SELECT FOR UPDATE
- Can not use dry run for query in for loop
- [REQUEST] Help to implement Google Query Language
- Parameters from sqlfn inside fields alias are not correctly passed to JDBC
- Korma 0.5.0-RC1 breaks "with" on many-to-many relationships HOT 1
- Subselect breaks after uberjar using composed queries
- hook into select query field values
- http://sqlkorma.com/ is down HOT 6
- Heads up to MySQL users โ mysql-connector-java "8.0.23" has a BREAKING change
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from korma.