Comments (10)
I'm using Waitress and prometheus-client 0.4.1 is still working for me
from django-prometheus.
from django-prometheus.
Looks like the unit tests are failing: #87
File "/home/travis/build/korfuri/django-prometheus/django_prometheus/testutils.py", line 48, in getMetricFromFrozenRegistry
for n, l, value in metric.samples:
ValueError: too many values to unpack (expected 3)
I think this is the relevant PR: prometheus/client_python#300
I haven't found the actual change, but metric.samples
is being used differently e.g. https://github.com/prometheus/client_python/pull/300/files#diff-52e98fdb8931e88f7d37feb48ba6ded2L51
from django-prometheus.
Hi!
Any news on this?
I am one of the Debian maintainers for this package and it currently risks being excluded from the next release because currently it fails to build. I am tempted to patch the package as per #88, but that is lacking the changes requested in #84. I could implement those, but I would not like to end up with different metrics names than the ones you end up with! (For example, following that change, I'd also remove _total_
from other metric names...
from django-prometheus.
I suggest this should be fixed by pinning the prometheus_client version to <0.4.0
now, then releasing a new large version bump with updated metric names and so on matching the new scheme that is >=0.4.0
from django-prometheus.
@bz2 Any ETA on that new release? Right now the situation (in Debian) is that prometheus_client is at 0.5.0, and that this package fails to build (normally, we don't keep old libraries around). I would like to patch it so it can be included in the next stable release, but the deadline for that is in a couple of weeks.
from django-prometheus.
@TheTincho I'd happy do the work in time for buster freeze, but don't have the ability to make a release. I have poked @korfuri by email to see if he wants help with maintaining this package.
Also checked the mysqlclient-python that needed fixing as well, but isn't a dep in the Debian packaging, and doesn't have that updated fork packaged anyway yet?
from django-prometheus.
@bz2 I would be happy to work with an unreleased patch. Ideally, the metric names would stay the same in the release later, so users don't get their timeseries screwed up in the next update, but even if we don't get that it would be better than no package.
I don't know what's the story with the mysqlclient library.. It indeed is not a dependency now, would it be in the next release?
from django-prometheus.
I think MySQL is an optional dependency: https://github.com/korfuri/django-prometheus#monitoring-your-databases
from django-prometheus.
@TheTincho Doesn't need to be a debian binary dependency - is a driver that provides for django.db.backends.mysql
, and is needed for running the end to end tests (which I guess are not plugged in to dep8).
from django-prometheus.
Related Issues (20)
- When I install django_prometheus the tests are failing
- Celery Worker Questions HOT 1
- Histogram of requests processing time does not honor PROMETHEUS_LATENCY_BUCKETS
- Supporting Django 4.1 HOT 2
- Cannot see exemplars in the metrics
- It prevents application from resolving DB URL HOT 2
- Custom metric does not work HOT 4
- Wrong Metrics being published
- 'Counter' object has no attribute '_value' HOT 2
- Support for Django 4.2 and Psycopg3 HOT 5
- django_migrations_unapplied_total = 1 but no migrations are unapplied HOT 2
- RedisCache not working
- Exclude metrics by view (or other criteria) HOT 2
- Move to psycopg3 HOT 1
- Custom namespace HOT 1
- RAM keeps going up when scraping metrics
- Unable to monitor a database | django_prometheus.db.backends is not an available backend HOT 2
- PrometheusEndpointServer throws an exception, after which the endpoint is not available and not restart
- django_http_requests_before_middlewares_total,Shouldn't this indicator be a line that keeps rising? HOT 3
- django_http_requests_latency_seconds_by_view_method_bucket wrong calculation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-prometheus.