Coder Social home page Coder Social logo

Comments (9)

koral-- avatar koral-- commented on June 8, 2024 1

I mean using:
csvFileURI = "https://docs.google.com/spreadsheets/d/REDACTED/export?format=csv"
Intermediate = between source spreadsheet and result XML.

from android-gradle-localization-plugin.

koral-- avatar koral-- commented on June 8, 2024 1

OK, thanks so there is a bug in XLS(X) parsing. I'll investigate it.

from android-gradle-localization-plugin.

koral-- avatar koral-- commented on June 8, 2024 1

I was able to reproduce this issue.
On spreadsheet used in unit tests, created in 2015 everything works fine. However, a brand new document with copy-pasted content behaves differently.

Some cells eg. never touched rows or columns, are expected to be nulls or not to exist at all. However, they are returned as empty strings with current settings.
Such behavior is permitted by documentation so we need to adapt to this. I'll investigate how to solve it (the naive solution is to filter out empty rows and columns).

For now workaround is to use CSV (in case of Google sheets) or (if formulas are needed or input comes from XLS-only source) to remove empty columns and rows. Not sure how it looks like in Excel, probably it is sufficient to delete empty columns which were touched.

from android-gradle-localization-plugin.

koral-- avatar koral-- commented on June 8, 2024 1

Should be fixed in v1.0.19.
Now rows and columns containing only effectively empty (incl. missing and nulls) cells are ignored.
If column starts with empty cell but contains non-empty row then explicit error is thrown unless column is configured to be ignorable.

from android-gradle-localization-plugin.

koral-- avatar koral-- commented on June 8, 2024

Is it reproducible if you change intermediate format to CSV?

from android-gradle-localization-plugin.

sp0rk avatar sp0rk commented on June 8, 2024

Do you mean changing xlsFileURI to csvFileURI and hosting the translations differently? I don't understand what you mean by intermediate format. I have not played around with csvGenerationCommand if that's what you mean

from android-gradle-localization-plugin.

sp0rk avatar sp0rk commented on June 8, 2024

When changing xls to csv as the intermediate format the issue disappears. So it seems to be only present with xlsFileUri / ?format=xlsx

from android-gradle-localization-plugin.

sp0rk avatar sp0rk commented on June 8, 2024

No worries, please ping me back here once you patch this up. Cheers 🍻

from android-gradle-localization-plugin.

sp0rk avatar sp0rk commented on June 8, 2024

Wow. Thanks for swift action. Cheers :)

from android-gradle-localization-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.