Coder Social home page Coder Social logo

Correct use of Unirest.pipe about unirest-nodejs HOT 8 CLOSED

kong avatar kong commented on August 20, 2024
Correct use of Unirest.pipe

from unirest-nodejs.

Comments (8)

nijikokun avatar nijikokun commented on August 20, 2024

This is a little tricky, pipe won't work on .end too much sugar going on there. This has to do with something I've been wanting to change around, but it will make things a little different going forward.

.end() does the whole shebang and instead I would rather return a request instance the whole way along instead. True aliasing.

from unirest-nodejs.

cosmicflame avatar cosmicflame commented on August 20, 2024

It does actually work and save the file though... Presumably this is a matter of "might work sometimes, but not supported" as it were, then?

from unirest-nodejs.

nijikokun avatar nijikokun commented on August 20, 2024

Ah, it will work because it is returned:

https://github.com/Mashape/unirest-nodejs/blob/master/index.js#L489

However, it's not as pure as request.get().pipe(); would be.

from unirest-nodejs.

cosmicflame avatar cosmicflame commented on August 20, 2024

So... a-ok correct usage of Pipe for writing files? :)

from unirest-nodejs.

nijikokun avatar nijikokun commented on August 20, 2024

File manipulation is easier using request directly right now in my opinion.

from unirest-nodejs.

cosmicflame avatar cosmicflame commented on August 20, 2024

The Unirest API is much nicer, though ;)
I'm trying to get an app I'm working on down to using a single HTTP client library. If I'm reading your responses correctly (which is to say that it will work, but this is an area where Unirest will improve in the future) then mission accomplished! :)

from unirest-nodejs.

nijikokun avatar nijikokun commented on August 20, 2024

Alright, closing this then :)

from unirest-nodejs.

cosmicflame avatar cosmicflame commented on August 20, 2024

Thanks for the help, and thanks most of all for unirest-nodejs - this library is making my job a whole lot easier and nicer! :D

from unirest-nodejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.