Comments (6)
Spent some time yesterday trying to use the annotation to point to a KongIngress
and found I was getting log messages that the plugin could not be found.
Looking at the code, it appears that getKongPlugin is being used to retrieve all types of CRD defined in annotations, where getKongIngress should be used for these.
from kubernetes-ingress-controller.
Came to report the same thing. I couldn't get this to work at all when using the annotation. Like @devdavidkarlsson mentioned, the name matching works better but I was still unable to get changes to be picked up until I delete/recreate the Ingress resource after the KongIngress is updated.
from kubernetes-ingress-controller.
Hi all,
Thank you for the report.
I've been going through the issues and addressing them one by one.
I'm going tot take this up next and provide a fix soon. Stay tuned!
from kubernetes-ingress-controller.
I think the annotation that is document is incorrect.
As per docs, the annotation should be ingress.plugin.konghq.com
while really the required annotation is configuration.konghq.com
.
Can you guys any of you try that? Thanks!
from kubernetes-ingress-controller.
Yep, that was it! It still doesn't pick up changes unless I delete/recreate the Ingress
, but it's at least reading the values from a shared resource with that annotation change. Maybe another ticket would make sense for live updates?
from kubernetes-ingress-controller.
Yep, that was it!
Nice! I will make a PR to update the documentaion.
It still doesn't pick up changes unless I delete/recreate the Ingress, but it's at least reading the values from a shared resource with that annotation change. Maybe another ticket would make sense for live updates?
This was left as a future TODO in the past in the code base. I guess it warrants another issue so please open one up.
Thank you for trying the above annotation! Stay tuned for fixes.
from kubernetes-ingress-controller.
Related Issues (20)
- Emit k8s events for fallback configuration
- Expose fallback configuration metrics HOT 1
- Admission webhook observability
- KIC + Konnect with sanitizer enabled continues to update consumer resources HOT 2
- Fallback configuration exploratory testing HOT 4
- Do not send config to Kong Gateway when no changes occurred
- Implement backfilling broken objects from last valid cache state
- Hot reload of mtls cert is broken. KIC can't fetch secret.
- Run Gateway API conformance with admission webhook HOT 1
- Refactor getting plugin related Kong entities in Kong state to store pointers to the entities
- Set "Programmed" status of custom entities HOT 1
- Support custom entities in failure domain
- Generate multiple entities if a `KongCustomEntity` is attached to multiple other entities
- Enable `KongCustomEntity` by default
- `TestMetricsAreServed/with_push_error_and_FallbackConfiguration_enabled/` is flaky
- Document cross namespace plugin attachment
- Release v3.2.0 HOT 1
- Fix failing GRPC conformance test HOT 3
- Specifying a nonexistent plugin name via `konghq.com/plugins annotation` is silently ignored, configuration is applied with that plugin HOT 1
- Resolve conflicts in GRPCRoute conformance testing. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kubernetes-ingress-controller.