http-log plugin: Host header not including port about kong

[ADD-SP]

@dingjiayi Thanks for your report. I'd like to clarify one thing.

endpoint receive request with host head: Host: host_name:8080

Do you mean the Host header as part of the Kong request log sent by the http-log plugin? Or the Host header of the request that was used to send the Kong request log?

My understanding is that you configured the http-log plugins using http_endpoint="http://host_name:8080/log", and the logging server received a logging request from this plugin, and the Host header of this request is host_name instead of host_name:8080. Am I right?

[dingjiayi]

@ADD-SP

My understanding is that you configured the http-log plugins using http_endpoint="http://host_name:8080/log", and the logging server received a logging request from this plugin, and the Host header of this request is host_name instead of host_name:8080. Am I right?

Right. Sorry for my unclear description.

This is caused by line 117 ["Host"] = host, as blow

kong/kong/plugins/http-log/handler.lua

Lines 116 to 121 in 4e006aa

	local headers = {
	["Host"] = host,
	["Content-Type"] = content_type,
	["Content-Length"] = content_length,
	["Authorization"] = userinfo and "Basic " .. encode_base64(userinfo) or nil
	}

If it's confirmed to be a bug, I would be willing to submit a PR to fix it.

I think it could be resolved by directly removing the code on line 117. Just like many other HTTP client libraries, lua-resty-http automatically sets the Host header in the underlying layer when the upper-layer request doesn't have a Host header set.

[ADD-SP]

@ADD-SP

My understanding is that you configured the http-log plugins using http_endpoint="http://host_name:8080/log", and the logging server received a logging request from this plugin, and the Host header of this request is host_name instead of host_name:8080. Am I right?

Right. Sorry for my unclear description.

This is caused by line 117 ["Host"] = host, as blow

kong/kong/plugins/http-log/handler.lua

Lines 116 to 121 in 4e006aa

	local headers = {
	["Host"] = host,
	["Content-Type"] = content_type,
	["Content-Length"] = content_length,
	["Authorization"] = userinfo and "Basic " .. encode_base64(userinfo) or nil
	}

If it's confirmed to be a bug, I would be willing to submit a PR to fix it.

I think it could be resolved by directly removing the code on line 117. Just like many other HTTP client libraries, lua-resty-http automatically sets the Host header in the underlying layer when the upper-layer request doesn't have a Host header set.

I think this is a bug, PR is welcome. @dingjiayi