Comments (7)
I would think the DNS library would treat localhost resolution as ip 127.0.0.1
It didn't until recently. See Kong/lua-resty-dns-client#50
Good idea on the request termination short circuiting, will investigate there...
from kong-plugin-zipkin.
Looks like it's failing from the call-site for the load balancer data.
My guess is that a DNS lookup failed, so the ip
is nil
and it went to the next balancer candidate? Could you check if that was the case by seeing if you have a DNS failure earlier in your logs?
Either way it's a bug that needs fixing in this plugin, thankyou for the report!
from kong-plugin-zipkin.
@james-callahan the service this plugin errors on is set to proxy to http://localhost:8001/status (Kong admin api status endpoint), but it will never do so anyways because the request termination plugin is enabled on this particular kong route. I would think the DNS library would treat localhost resolution as ip 127.0.0.1 but somehow it must be nil(most likely because request termination short circuits everything so balancer was never involved, just a guess).
from kong-plugin-zipkin.
@james-callahan I did test that PR just now too on 1.0 and the lua nil pointer exceptions are gone so that did do the trick for short circuit tx's(and also validated no further places needed it I missed 😄 )
from kong-plugin-zipkin.
https://luarocks.org/modules/kong/kong-plugin-zipkin does not seem updated yet after the PR was merged. Guess yall are running that manually?
from kong-plugin-zipkin.
It's merged but not released.
The next plugin release will be done in sync with the next kong patch release.
from kong-plugin-zipkin.
All righty, sounds good to me I will just drop in the zipkin code manually for now as opposed to luarocks installing until the next official Kong release(hopefully this month to address some problems I see on 1.0 :P ).
from kong-plugin-zipkin.
Related Issues (20)
- Exception in Annotate Assert HOT 6
- Global sample ratio overrides route-specific HOT 3
- Allow customize localEndpoint.serviceName HOT 5
- Loud logging at the moment. HOT 2
- A question about processed time of a request in Kong HOT 1
- Configurable ServiceName HOT 4
- Can zipkin collect data through kafka? HOT 6
- Why does zipkin lose so much data with high concurrency? HOT 3
- Plugin don't work when apply to Services or Routes HOT 2
- Numerous data problems HOT 1
- Connections in dependency graph, should it be like this? HOT 2
- Consider using `localEndpoint` instead of `peer.*` tags HOT 6
- Honor x-b3 request headers HOT 1
- Feature Request: implement W3C TraceContext traceparent header extract/inject HOT 18
- Assumption KONG_ACCESS_START will always be set in tx context. HOT 1
- Which plugin version for Kong 1.1.2? HOT 1
- krs, krf, kaf, kas, khs, kbf, kbs, khf HOT 1
- Kong doesn't sends traces to zipkin HOT 1
- Incorrect timestamps on Kong phase start/end logs in Jaeger UI HOT 5
- Feature request: Set dynamic tags through request headers HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kong-plugin-zipkin.