Comments (4)
This should have been fixed back in October with 174737f.
What version are you running?
from kong-plugin-zipkin.
I think @rsbrisci just set it as an environment variable, and maybe it came bundled with 0.14.1 in that case? If so I can force a luarocks install on it and get the latest that way. Will give that a go, thx.
from kong-plugin-zipkin.
Seems to be the case(to run log_by_lua*: ...lugin_zipkin_0_0_4_0-kong/plugins/zipkin/opentracing.lua), trying to add a luarocks install to overwrite it adds this to my build, first time I have seen of this msg before:
Step 22/38 : RUN luarocks install kong-plugin-zipkin
---> Running in 745db4762940
Warning: The directory '/root/.cache/luarocks' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing /usr/local/bin/luarocks with sudo, you may want sudo's -H flag.
Installing https://luarocks.org/kong-plugin-zipkin-0.1.1-0.src.rock
Will not remove kong-plugin-zipkin 0.0.4-0.
Removing it would break dependencies for:
kong 0.14.1-0
Use --force to force removal (warning: this may break modules).
Failed removing.
kong-plugin-zipkin 0.1.1-0 is now installed in /usr/local (license: Apache 2.0)
Checking stability of dependencies in the absence of
kong-plugin-zipkin 0.0.4-0...
Would it be okay to --force remove under these circumstances?
https://github.com/Kong/kong/blob/master/kong-0.14.1-0.rockspec#L39
Maybe this ^ is the issue, since the Kong release bundled it and includes an early iteration in the rockspec?
Edit - Yep I see its in the lua/5.1/kong_plugin_zipkin_0_0_4_0-kong/ folder then /plugins/zipkin/{src here}, any reason this was not treated like every other custom plugin and got a dedicated folder? I suppose I could overwrite the rockspec after I pull the tar, then rm rf this directory and install via luarocks... A bit painful might just wait to use zipkin on 1.0 .
from kong-plugin-zipkin.
But yeah I see how I could probs patchwork around to get newest one running on 0.14.1 but not worth the time since 1.0 is close by. will just deploy latest on that, hopefully they are decoupled now xD .
from kong-plugin-zipkin.
Related Issues (20)
- Exception in Annotate Assert HOT 6
- Global sample ratio overrides route-specific HOT 3
- Allow customize localEndpoint.serviceName HOT 5
- Loud logging at the moment. HOT 2
- A question about processed time of a request in Kong HOT 1
- Configurable ServiceName HOT 4
- Can zipkin collect data through kafka? HOT 6
- Why does zipkin lose so much data with high concurrency? HOT 3
- Plugin don't work when apply to Services or Routes HOT 2
- Numerous data problems HOT 1
- Connections in dependency graph, should it be like this? HOT 2
- Consider using `localEndpoint` instead of `peer.*` tags HOT 6
- Honor x-b3 request headers HOT 1
- Feature Request: implement W3C TraceContext traceparent header extract/inject HOT 18
- Assumption KONG_ACCESS_START will always be set in tx context. HOT 1
- Which plugin version for Kong 1.1.2? HOT 1
- krs, krf, kaf, kas, khs, kbf, kbs, khf HOT 1
- Kong doesn't sends traces to zipkin HOT 1
- Incorrect timestamps on Kong phase start/end logs in Jaeger UI HOT 5
- Feature request: Set dynamic tags through request headers HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kong-plugin-zipkin.