Bug: Github oauth未正常工作 about koishi-plugin-github

[shigma]

@MaikoTan 这个 issue 大概是怎么回事？

[MaikoTan]

@MaikoTan 这个 issue 大概是怎么回事？

Idk, with the latest version now (5.0.2) I can only reproduce the error codes 422 and 408 in authorizing phase. (But I still am not able to make it work either, maybe not the same issue)
I would read some GitHub documents and investigate this issue later.

[MaikoTan]

koishi-plugin-github/src/server.ts

Lines 120 to 130 in 44b5845

	async getTokens(params: any) {
	return this.http.post<OAuth>('https://github.com/login/oauth/access_token', {}, {
	params: {
	client_id: this.config.appId,
	client_secret: this.config.appSecret,
	...params,
	},
	headers: { Accept: 'application/json' },
	timeout: this.config.requestTimeout,
	})
	}

Looks like the code here requests the URL with query parameter instead of HTTP body, is it expected?

[shigma]

Looks like the code here requests the URL with query parameter instead of HTTP body, is it expected?

I think I'm doing what the documentation says.

https://docs.github.com/en/developers/apps/building-oauth-apps/authorizing-oauth-apps#2-users-are-redirected-back-to-your-site-by-github

[MicroCBer]

As for my experience, if config.redirect is misconfigured, the api would be likely to return a 4xx error. Also, there seems not to be any configuration check here.

[colour93]

我也遇到了，无论是配置了 config.redirect 还是使用默认，都会出现如上问题，且最终绑定不成功