Body validation does not work? about open-api

[juliusza]

Thanks, you're awesome. Looks like I'll be able to replace swaggerize-express lib with this one after all.

[juliusza]

world.js

module.exports = {
    put: function (req, res, next) {
        console.log(req.body);
        res.json({ok: "ok"});
    }
};

main.js

const apiDoc = {
    swagger: '2.0',
    info: {
        title: 'A getting started API.',
        version: '1.0.0'
    },
    paths: {
        "/world": {
            "put": {
                parameters: [
                    {
                        in: 'body',
                        name: 'body',
                        required: true,
                        schema: {
                            type: "object",
                            properties: {
                                filtered: {
                                    description: "test",
                                    type: "boolean"
                                }
                            },
                            required: ["filtered"]
                        }
                    }
                ],
                responses: {
                    200: {
                        description: "ok",
                    },
                    default: {
                        description: "error",
                    }
                }
            }
        }
    }
};

const bodyParser = require("body-parser");
const express = require("express");
const openapi = require("express-openapi");
const http = require("http");
const app = express();

app.use(
    bodyParser.json(),
    bodyParser.urlencoded({ extended: false })
);

openapi.initialize({
    app,
    apiDoc: apiDoc,
    paths: "./api-v1/paths"
});

app.listen(3200);

setTimeout(function () {
    // Required property filtered is not set
    const postData = JSON.stringify({test: "test"});

    const options = {
        hostname: "127.0.0.1",
        port: 3200,
        path: "/world",
        method: "PUT",
        headers: {
            "Content-Type": "application/json",
            "Content-Length": Buffer.byteLength(postData)
        }
    };

    console.log("Making request");
    const req = http.request(options, res => {
        console.log("Got response from " + options.path, res.statusCode);
        req.on("data", data => console.log(data));
        req.on("end", data => console.log("END"));
    });

    req.on("error", err => console.log(err));
    req.write(postData);
    req.end();

}, 1000);

Got output:

Making request
{ test: 'test' }
Got response from /world 200

Expected output:

Making request
Got response from /world 400

[jsdevel]

The schema seems right. Have you looked at the sample projects? Here's a spec from the basic-usage project that seems to do what you want: https://github.com/kogosoftwarellc/express-openapi/blob/master/test/sample-projects/basic-usage/spec.js#L77

[juliusza]

I was breaking my head for hours as to why this doesn't work.

This unreleased change fixes the issue: 471f9a3#diff-168726dbe96b3ce427e7fedce31bb0bc

how about making a release? @jsdevel

[jsdevel]

@juliusza done. published @alrik 's PR as v1.5.0

[jsdevel]

@juliusza if the latest version works for you, would you mind closing this? Let us know if you still have problems. I see why it didn't work for you now, as defining paths in the global apiDoc wasn't added until @alrik 's PR. Should be good to go now.

[jsdevel]

You're welcome! Happy to have you! Don't hesitate to report issues here.