Coder Social home page Coder Social logo

Comments (19)

mgonzales71 avatar mgonzales71 commented on June 28, 2024

2015-05-14_00-53-42

from skin.titan.

mgonzales71 avatar mgonzales71 commented on June 28, 2024

2015-05-14_00-56-42

from skin.titan.

marcelveldt avatar marcelveldt commented on June 28, 2024

Hi Mario, thanks for noticing!
Will fix it tomorrow

from skin.titan.

mgonzales71 avatar mgonzales71 commented on June 28, 2024

oops! ;)

new cosmetic issues with list, overlays, etc - no rush sir! - just FYI

2015-05-15_13-05-16

from skin.titan.

mgonzales71 avatar mgonzales71 commented on June 28, 2024

oh - btw - I liked the updated fonts - right now you have a mixture of ubuntu and old roboto - what didn't look right to you with the new fonts?

I did notice a couple of double font name entries looking over the existing font sets - i will look at the entire list this weekend and see if I can clean up and remove the entries at the very least :)

one i noticed at first glance was this double entry:

    <font>
        <name>Reg28</name>
        <filename>Regular.ttf</filename>
        <size>28</size>
    </font>

    <font>
        <name>Reg28</name>
        <!--Small-->
        <filename>Regular.ttf</filename>
        <size>32</size>
    </font>

from skin.titan.

mgonzales71 avatar mgonzales71 commented on June 28, 2024

also noticed unfocused list item (A) is not same height as focused list item (B) if that matters:

2015-05-15_13-18-20

from skin.titan.

marcelveldt avatar marcelveldt commented on June 28, 2024

Hi Mario,

fixed the issue with the overlays in biglist/lowlist, thanks for noticing.

As for the different line height in the normal list: that has Always been like that, it's on purpose because the focused item shows the info while the unfocused item doesn't.

The fonts are indeed different. I did that back then to create a difference between light, regular and bold. I have no problem in updating the font as long as the main regular font stays as close to what it is now. Also keep in mind that only limited fonts are considered fully opensource and can be redistributed with the skin.

So, it's not that I didn't like your update with the font but it needs to be reviewed. A lot of text just got way too big when I tested it so I did a quick revert of the font files only. It's okay to update the fonts, in fact the "light" font can be improved but it must stay as close to what it is now because the current font suits the skin and all sizes are adjusted for the used font. If the new font differs in size it's a hell of a job to get everything adjusted to that. You have to check every single screen/view in the skin if all content still fits. Both with normal font-setting and with the "large" option.

If you have some spare time and are willing to review every part of the skin to make the change be my guest ;-)

from skin.titan.

mgonzales71 avatar mgonzales71 commented on June 28, 2024

I will work more on fonts this weekend for you. I may actually create a new font set for testing and on-going adjustments until all views can be checked out.

from skin.titan.

marcelveldt avatar marcelveldt commented on June 28, 2024

that would be really great!!!

from skin.titan.

marcelveldt avatar marcelveldt commented on June 28, 2024

btw: what do you think of my adjustments to the list views today ?

from skin.titan.

mgonzales71 avatar mgonzales71 commented on June 28, 2024

looks good - did you get any screams from the beta users on the forum? i haven't read any posts yet today,

from skin.titan.

marcelveldt avatar marcelveldt commented on June 28, 2024

My attempt from yesterday did get some negative attention, it was the wrong direction. Today I worked a bit more on it and now it looks much better. Also confirmed on the forum :-)

from skin.titan.

mgonzales71 avatar mgonzales71 commented on June 28, 2024

hehe - yea I was shocked at the change in direction myself - the rounded corners mostly since I thought you wanted more square/sharp edges. I like the updated look over yesterdays so right direction - funny how it's the little touches/changes that can be the most noticed and get the most feedback from folks :)

from skin.titan.

marcelveldt avatar marcelveldt commented on June 28, 2024

I left the rounded corners in... Still haven't decided yet if I leave it in or not. Untill now I think it's a little touch that makes it perfect. The skin is still square/sharp edged but just a little rounding on the corners. For now I think I like it :-)

from skin.titan.

mgonzales71 avatar mgonzales71 commented on June 28, 2024

personally I like the slight rounded edges - so no real complaints there. makes things more organic - a good mixture of both works - just keep a balance I suppose and make sure it looks nice in the end!

at some point you may want to consider adding:

a "provide feedback" button in the skin settings
and an opt-in for anonymous skin usage statistics (on skin's first run?)

could help better understand the usage, demographics, hardware, etc

from skin.titan.

marcelveldt avatar marcelveldt commented on June 28, 2024

hehe, glad we agree on that :-)
I think it will stay this way. The skin looks more finished now.
Now getting that appearance settings stuff perfect.. will be a hell of a job to do but once finished it's amazing I think.

Good idea about the opt-in, something for on the "to do" list :-)

from skin.titan.

mgonzales71 avatar mgonzales71 commented on June 28, 2024

low list still has tiny cosmetic issues

i would suggest watched overlay on right side of list items maybe? having the watched overlays on the left in any of the lists feels strange actually but that is just me and the newness of it all still,

but i would move it to the right LOL hehe ;-)

screenshot000

from skin.titan.

mgonzales71 avatar mgonzales71 commented on June 28, 2024

oh fun fun fun - one more in addition to above ;-)

ratings / stars music OSD

screenshot004

from skin.titan.

marcelveldt avatar marcelveldt commented on June 28, 2024

forgot to update on this: all fixed in recent builds

from skin.titan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.