Comments (6)
Oh, that's also great!! I am upgrading right now, to test the changes, and keep implementing it. Thanks a lot for the library AND the updates!! :)
from chili.
@Fairlight8 Sounds like a potential bug, will have a look at it after my work today and update you.
from chili.
I think I have the reason and the solution. I inspected your code and I see that you use recursion, when building the type encoders. There are two arguments, a_type, and extra_encoders. The thing is that, you don't pass the extra encoders (or decoders) when doing the recursion. In fact, I think I solved that with a small change. Do you want me to submit a PR?
from chili.
@Fairlight8 sure ;)
from chili.
Actually I have fixed it and also added support for NewType and TypeVar ;) please update to 2.1.0 :)
from chili.
Hey again, @dkraczkowski ! I'm afraid that the problematic code is still not working. When changing ISBN for List[ISBN], it still gives an exception. Same issue as before. I created a PR : #15. I think that solves the issue when nesting subtypes.
from chili.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chili.