Coder Social home page Coder Social logo

Comments (2)

koaning avatar koaning commented on July 27, 2024

Shrinkage doesn't really make sense, or at least not for all transformers. In fact the current GroupedTransformer doesn't support it.

Agree!

Should the group columns be returned as they are from the .transform(X) operation?

It feels like it would be fine to default to not returning the group columns. Mainly because users could select them seperately in the pipeline if they were so inclined. Might make for a good parameter though.

Should the .transform(X) output maintain the input type? Hence if pandas dataframe maintain the index as well?

I would prefer not to rely on anything pandas specific with the advent of possible polars support. Is there a use-case you had in mind where that's required?

from scikit-lego.

FBruzzesi avatar FBruzzesi commented on July 27, 2024

Ok, these will definitely be (at least) two separate PRs, one for predictor and one for transformer (the predictor one could land late this week 😁)

Might make for a good parameter though

"passthrough" vs "drop" seems suitable

Is there a use-case you had in mind where that's required?

Absolutely not, I started to rely on indexes as less as possible, but since pandas and polars input/output are supported by scikit-learn, I am wondering what is the behavior one should expect.

from scikit-lego.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.