Comments (2)
Shrinkage doesn't really make sense, or at least not for all transformers. In fact the current GroupedTransformer doesn't support it.
Agree!
Should the group columns be returned as they are from the .transform(X) operation?
It feels like it would be fine to default to not returning the group columns. Mainly because users could select them seperately in the pipeline if they were so inclined. Might make for a good parameter though.
Should the .transform(X) output maintain the input type? Hence if pandas dataframe maintain the index as well?
I would prefer not to rely on anything pandas specific with the advent of possible polars support. Is there a use-case you had in mind where that's required?
from scikit-lego.
Ok, these will definitely be (at least) two separate PRs, one for predictor and one for transformer (the predictor one could land late this week 😁)
Might make for a good parameter though
"passthrough" vs "drop" seems suitable
Is there a use-case you had in mind where that's required?
Absolutely not, I started to rely on indexes as less as possible, but since pandas and polars input/output are supported by scikit-learn, I am wondering what is the behavior one should expect.
from scikit-lego.
Related Issues (20)
- [DOCS] Document KlusterFoldValidation HOT 3
- [DOCS] Broken links on Home page to installation and user guide sections
- [DOCS] Remove netlify docs HOT 2
- [DOCS] Proposed addition: Adding a Quickstart or Overall User Guide Landing Page
- [DOCS] Latex markdown mixup HOT 1
- [DOCS] Missing explanation on how to run the documentation locally HOT 1
- [BUG] Rename `transform_train` to `resample`. HOT 8
- `linear_model.LowessRegression`
- `decomposition.pca_reconstruction.PCAOutlierDetection` HOT 1
- `decomposition.umap_reconstruction.UMAPOutlierDetection` HOT 5
- Delegate Missing Values and Categorical Handling in `GrouperTransformer` and `GrouperPredictor` HOT 6
- [FEATURE] Narwhals migration for dataframe-agnostic codebase HOT 23
- [BUG] zero_inflated_regressor.py HOT 1
- [FEATURE] equivalent to sklearn discovery module HOT 7
- [BUG] Fairness regularization HOT 1
- ModuleNotFoundError: No module named 'narwhals' when using RepeatingBasisFunction HOT 3
- [FEATURE] Ability to stratify with cols that contain some Nans values, this way people can hyperparameter tune best imputation methods HOT 1
- [BUG] CI/CD Failing
- [DOCS] linear_model missing docstrings HOT 2
- [BUG] regression in grouped estimator HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scikit-lego.