koajs / koa Goto Github PK

since we kind of expect developers to attach their own properties to context, it may be nice to warn when a property is overwritten. this is to avoid conflicts with different plugins/extensions/etc. we can also do something like app.context(obj, dontWarnMe) where dontWarnMe is a Boolean and default true during development.

no one remembers to do this by default and node explodes

• this.response.lastModified = Date() - since i'm too lazy to do this.set('Last-Modified', new Date().toUTCString()). plus we can normalize people's date strings.
• this.response.etag = '12345' - wrap the etag in "s if not already.
• this.response.link()
• this.response.location()

most of the other stuff i can think of are already handled by higher level stuff. or people won't use. if you don't have any opinions on these, i will implement them after you implement this.response and this.request.

when header isn't sent

so shit doesn't explode

such as https://github.com/senchalabs/connect/blob/master/lib/utils.js#L61

so you can do something like

this.error(404)

vs.

var err = new Error()
err.status = 404
this.error(err)

or, another way to say it is to convert the body to a respondable type: buffer, stream, or string. generally, this should only be used in upstream middleware. we can make it private so people don't abuse it.

this way, we can avoid doing: https://github.com/koajs/compress/blob/master/index.js#L69

maybe

in libs but add a few methods here, so common

need to look into this, some errors aren't being caught

jshttp/negotiator#8

instanceof Stream is lame

instead of yield next? so used to next() in connect that it mind-fucks me a bit

right now, app.onerror is added to the the error event listener automatically. what happens if users don't want to use it? doing app.removeListener('event', app.onerror)` is a little annoying. instead i suggest the following:

• remove app.onerror
• remove app.outputErrors
• at the app.callback() stage, warn/throw if no event listeners have been added
• automatically add the default listener in development

app.callback = function(){
  // ...

  if (!app.listeners('error')) {
    if (this.env === 'development') {
      console.warn('You should add your own error handler.');
      app.on('error', function(err) {
        console.error(err.stack);
      })
    } else if (this.env !== 'test') {
      throw new Error('Add your own error handler!');
    }
  }

  return function(req, res){
  // ..
})

if we end up going with the dispatcher this will be simple

since we will have app.context(), app.request(), and app.response(), i guess we should have something like app.mixin() where you can do:

app.mixin({
  context: {},
  request: {},
  response: {}
})

so you can do with a plugin:

app.mixin(require('koa-context-something'))

maybe app.plugin(). maybe a different, better name. also, an app.inherit(parentapp) would be nice as well, especially if you mount apps.

so it has the same middleware signature as connect/express

i personally don't like qs. would be nice if you removed it as a dep and used the native querystring module in core, then moved qs to a separate repo.

does basic auth really need to be in core?

Like this

app.use(function *(next) {
    var start = new Date;
    yield next;
    var ms = new Date - start;
    console.log('%s %s - %s', this.method, this.url, ms);
});

Is there a reason for that?

or similar, less ugly name would be nice but meh

https://github.com/koajs/koa/blob/master/lib/application.js#L62 currently returning server.listen(), thoughts?

with some design decisions etc

would be more organized

In general I don't like this for the average use-case and "hot" methods, but I do prefer this.request.etag to this.get('ETag'), this.request.length, this.response.length, this.response.header etc, but the common cases we have would delegate: this.body = foo == this.response.body = foo. something to think about

more common shit, all as wrappers for vanilla node libs when appropriate.

• common logger
• compression
• cookie session
• db session
• conditional get
• jsonp
• etag
• directory
• csrf protection
• request limits
• rate limiting
• favicon
• methodOverride
• basicAuth
• route
• domains
• static
• timeout

app.keys = new Keygrip or sth

update the year to 2013. Also, you should add the repository field to package.json.

add tests, content-typ, content-length, transfer-encoding

reopening a clean issue. references: #34 #36

will do this after #67

not sure what's up with this, it wont let me edit the home page https://github.com/koajs/koa/wiki

seems like we can't really wrap just one stream so we may want to consider this, knocks a good 1000rps off but eh. seems a little tricky to do with middleware since we have to terminate it lower, similar issue to the compress middleware

would be nice if koa didn't touch the original req/res. since we're building a wrapper around them, i don't see why it would be necessary.

example is:

  /**
   * Set request URL.
   *
   * @api public
   */

  set url(val) {
    this.req.url = val;
  },

Wish it were something else like:

  get url() {
    return this._url || this.req.url
  },

  set url(val) {
    this._url = val
  }