Comments (9)
for the most part subapps won't collide, if people build subapps that are meant to be mounted to any application I'd definitely suggest that they shouldn't be doing prototype manipulation anyway so I think we can skip that part. It's tempting to even remove app.context() for now and just encourage modularity via foo(this)
, it's not super pretty but neither is global stuff I suppose yield parse(this)
vs yield this.parse()
sort of deal
from koa.
Ah yeah. It's easier to just do wrap(app) at this point. I'm all for removing app.context()
from koa.
k sweet let's do that for now
from koa.
consensus for now is to assume protos are nice enough to use without extending for now haha
from koa.
ohhh you can't extend at all now. i still want to extend it. i just think modules should extend it from require('module')(app)
instead of app.context(require('module'))
or app.mixin(require('module'))
.
from koa.
I think it's an anti-pattern, a tempting one, but definitely an anti-pattern, tough call but I'd rather leave it out completely for now
from koa.
at least until everything else is well defined and finished, maybe after 0.1.0
from koa.
I think it's an anti pattern if users rely on it, but it's fine for extending koa. I would make it private. It would be annoying to do things like yield body(this)
from koa.
that's annoying but it's also annoying to hunt down where these magical methods are coming from if you're unfamiliar with the app, but ugly indeed
from koa.
Related Issues (20)
- [feat] send json type content when call ctx.throw HOT 1
- [fix] Has callback() changed return type? Now error from eslint HOT 5
- [feat] Could a listen() shortcut function be added also for http2? HOT 4
- [fix] Some things cannot be found in the database where condition search, unless the where condition search ID HOT 3
- koa 2.14.7 No generics,I want to be able to add generics HOT 1
- [feat] when will koa 3.0 be released? HOT 3
- Koa main website example code snippets disappear HOT 4
- [feat] Objects as middleware HOT 7
- [feat] Support Web (WHATWG) stream, Blob and Response HOT 6
- Consider alternatives to http-assert (including none at all) HOT 4
- [fix] Send response as buffer HOT 4
- async issue on app.listen(...) HOT 4
- [fix] I can not get query parameters about Korean HOT 3
- [feat] Spanish translation for docs
- Routing sucks, moving back to express. HOT 1
- [fix] ctx value persists to next request after mutating ctx object HOT 3
- if "\@" in url ,the redirect result doesn't match the host of the new URL() HOT 2
- [feat] Replace npm dependency "only" HOT 2
- [fix] Version 2.x introduced the URL object, which is not compatible with Node versions below 10.
- Client disconnect HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from koa.