republish as @koa/cors? about cors

[ianstormtaylor]

Or even get the koa-cors maintainer to give up the name ideally.

But yeah, +1 because it's hard to remember what kcors is when looking through dependencies...

[stevehipwell]

I'm not sure that @koa/cors is the best name for this package as it's not consistent with the other core koa packages. Ideally you could get the koa-cors package name, otherwise maybe something more like koa-cors-official.

[stevehipwell]

@jonathanong - If this is the policy for all koa packages then it makes sense, however you might want to notify the relevant TypeScript definition authors that the package has moved as @koa/cors doesn't have any definitions but kcors does.

[raphaelsoul]

currently I copy declare code from @types/koa2-cors to my index.d.ts

declare module "@koa/cors" {
    import * as Koa from 'koa';
    namespace cors {
        interface Options {
            origin?: string | ((ctx: Koa.Context) => boolean | string);
            exposeHeaders?: string[];
            maxAge?: number;
            credentials?: boolean;
            allowMethods?: string[];
            allowHeaders?: string[];
        }
    }

    function cors(options?: cors.Options): Koa.Middleware;

    export = cors;
}

[fengmk2]

I'm ok for this. @jonathanong just do it and add a deprecated message on the kcors package.

[jonathanong]

done

[jonathanong]

i do not have access to kcors

[jonathanong]

@stevehipwell we can slowly move koa packages to @koa/*, which would be somewhat ideal Imo

[vladshcherbin]

The name without @ is better because now it differs from the rest of koa family and is the first one in dependency list, even above packages that start with a letter.

Will stick with kcors for now.

[fengmk2]

done https://www.npmjs.com/package/@koa/cors