Comments (3)
jonathanong
commented on May 3, 2024
sounds like a bug to me! maybe support false?
from compress.
felixsanz
commented on May 3, 2024
threshold: false doesn't make much sense to me, it's confusing the intention.
I think threshold: 0 is just fine since you want to compress from that size.
The thing is that compressing 0 bytes doesn't make sense. But threshold: 1 is weird as an option.
from compress.
jonathanong
commented on May 3, 2024
sorry for the late update. looks like the code is updated so that this is no longer relevant.
if (threshold && ctx.response.length < threshold) returnfrom compress.
Related Issues (20)
- remove jest --forceExit
- tests: remove callbacks HOT 1
- Brotli used, even if not in Accept-Encoding header (v4.0.0) HOT 4
- Not using the correct encoding HOT 2
- If no Accept-Encoding header is sent, koa-compress may compress the response HOT 9
- Can this be used without koa? HOT 1
- koa-compress not compressing response body. HOT 1
- 4.x seems to be significantly slower (not related to brotli!) HOT 4
- Expand documentation HOT 12
- Brotli Defaults HOT 13
- "flush" as it is used in tests HOT 1
- Default Brotli compression level is too slow HOT 16
- Q: `options.defaultEncoding` default `idenity`, typo? HOT 1
- Error [ERR_HTTP2_HEADERS_SENT]: Cannot set headers after they are sent to the client HOT 1
- Content-Length Not Set HOT 2
- 5.1 did not set brotli default quality to 4 correctly HOT 1
- An in-range update of eslint-plugin-flowtype is breaking the build 🚨 HOT 7
- An in-range update of supertest is breaking the build 🚨 HOT 4
- Check that response hasn't been sent already HOT 2
- consider adding `response.originalLength` property HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compress.