Comments (4)
You need to return a promise if you do asynchronous activities, which includes calling next IIRC (it's been a while since I've worked with Koa).
Here's a working example: https://gist.github.com/1f0670e88911cac546dc80548bca1865
from compose.
@PlasmaPower your example does work. I'm struggling to understand why though. This feels like Promise black magic haha.
Thoughts on this being an antipattern? My experience with callbacks is that you need to call next before moving on.
from compose.
You're probably thinking of the express model. In Koa, you almost always return a promise.
from compose.
Expanding on @PlasmaPower's answer: Promises need to be chain returned otherwise any of them will resolve and Koa flushes the response. All next calls return a promise guaranteed because of how compose works - meaning that even if you call next expecting it will be a normal function it's actually a promise.
from compose.
Related Issues (20)
- If `fn` is an asynchronous function, this `try catch` will be useless οΌ HOT 2
- I found that some code in the source code like `Promise.reject(),Promise.resolve()` seems redundant HOT 1
- Behavior changes on 4.2.0 HOT 5
- Add debug logs before and after each middleware executes HOT 1
- License is not included
- I donβt understand how the error is thrown when I find that next is called repeatedly. HOT 2
- Why use Promise.resolve() to wrap the execution results of each middleware? HOT 2
- Abnormal middleware errors occurred and KOA could not catch error events. How about the following changes
- [Question/Proposal] Sync/Async execution HOT 1
- Set default branch to next, default npm release to v3 HOT 1
- guard against unhandled next()s in development HOT 15
- Reorganize tests, and switch to Jest HOT 5
- when i use koa-compose with koa-router, koa-router does not work. HOT 6
- [Q&A] About Promise in the source code. HOT 1
- Outdated yield tests
- I can't catch the error ~ HOT 6
- Can't use destructuring with async await. HOT 2
- Unit test to verify if it handles wrapped non-async functions is wrong. HOT 1
- Multiple next with non async function HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compose.