Coder Social home page Coder Social logo

Comments (3)

jlai avatar jlai commented on May 6, 2024

No plans at the moment unless someone contributes one. According to https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html for non-TypeScript projects it's preferable to have a separate package published to @types

from bunyan-logger.

sjmcdowall avatar sjmcdowall commented on May 6, 2024

BTW -- I did submit and added a TS file to @types .. so it's there

from bunyan-logger.

landau avatar landau commented on May 6, 2024

No plans at the moment unless someone contributes one. According to typescriptlang.org/docs/handbook/declaration-files/publishing.html for non-TypeScript projects it's preferable to have a separate package published to @types

I disagree with this sentiment because it's easy to forget about the types. For instance, the ignorePath option is missing on RequestLoggerOptions https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c571148c8751daccabbcb639f3ae20ac83351111/types/koa-bunyan-logger/index.d.ts#L31

Added ignorePath here DefinitelyTyped/DefinitelyTyped#35264 Please review so it can be merged.

EDIT: This was merged and released! 🚀

from bunyan-logger.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.