Comments (1)
That's a good observation... In hindsight, I believe what you're suggesting is a better option.
I'll throw out another thought, for consideration.
If groupedByProp
is truly a constant (I'm treating it as such, but JavaScript doesn't support it), then calcScore
would be considered pure.
A simpler example:
const PI = 3.14;
const radius = c => c / 2 * PI;
So is radius
pure? It's depending on PI
?
If we just replaced PI
in radius
with 3.14
, then most people would quickly identify it as pure... but many people look at PI and think it's referencing something outside it's parameters, so it wouldn't seem to be pure.
My answer... in a language that truly supports constants there's no difference between using PI
or 3.14
in radius
, so it's pure...
However we're in JavaScript so it's not as clear...
Regardless, I think your observation is legit and a better option.
Best,
James
from ramdatutorial.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ramdatutorial.