Coder Social home page Coder Social logo

Comments (3)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 16, 2024
Correction. After looking at the source, the problem is that I was specifying a 
port number (http://localhost:4000/...), which your RegExp. didn't like. For my 
purposes, I just changed 1.8_0/plugins/default.js:11 to the following: 

return this.href.match(/^.*\.(?:jpe?g|gif|png|svg|bmp|ico|xbm)(?:[\?#].*)?$/i);

It doesn't look for a correct URL format, but regardless the expression, one 
can't know that a URL points to a valid image until one requests it, anyway, so 
it doesn't matter (to me).

Original comment by [email protected] on 29 Nov 2010 at 5:58

from hoverzoom.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 16, 2024
Well, thanks for posting the bug report as well as the fix!
I'll test your regexp, I had not reviewed it in a while, good you had a fresh 
look at it. Indeed, there is no need to test the beginning of the URL. 
Also, thanks for teaching me the non-capturing parentheses syntax :)

Original comment by [email protected] on 29 Nov 2010 at 9:13

  • Changed state: Started

from hoverzoom.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 16, 2024

Original comment by [email protected] on 7 Jan 2011 at 5:47

  • Changed state: Fixed

from hoverzoom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.