Disconnecting and shutting down database connection about knex

[alechirsch]

+1 for @gregbty

The knex instance is not destroyed after running seed. Any ideas?

[tgriesser]

Yep, covered now in: http://knexjs.org/#Installation-pooling

If you ever need to explicitly teardown the connection pool, you may use knex.destroy([callback]). You may use knex.destroy by passing a callback, or by chaining as a promise, just not both.

[tgriesser]

Yeah... those two are coming from the node-generic-pool library, which is a little hard to follow (I've got a fork here that I'm looking to use in the next release after the refactor I'm working on currently based on your other suggestions.

Basically, the database connection pool currently automatically shuts down with process.on('exit', ..., but if you have a better idea for how it should be set up, I'm all ears.

[moll]

It does indeed shut down on process exit, but what I'm talking about is requesting shutting down akin to server.close(). That — knex.close() — would suit much better with the new architecture we were talking about the other day. :)

I quickly just did the following to get going:

Knex.close = function() {
  var pool = Knex.client.pool
  pool.drain(pool.destroyAllNow)
}

[tgriesser]

Sounds good, I'll make sure it's in there... if you want to take a look at what I've got sofar here it is

[moll]

I just realized, shutting down in the exit event handler is entirely useless because the process gets killed right after the handler runs, even though there might be events in the eventloop.

[moll]

Example of the above:

process.on("exit", function() {
  console.log("My life ends!")
  process.nextTick(function() { console.log("FML") })
})

"FML" never put out.

[caseywebdev]

@moll That behavior is documented

[moll]

@caseywebdev Absolutely. I was merely pointing out that Knex doing its shutdown there is pointless.

[tgriesser]

Okay so it no longer does the process.exit thing, there is now a client.pool.destroy - http://knexjs.org/docs/clients/pool.html which handles calling the pool draining.

[aj0strow]

Please reopen. The link above 404s. How about something like:

var knex = require('knex')(config)
knex.close()
knex.disconnect()
// something else?

Would be nice for Gulp tasks and unit tests. I shouldn't have to process.exit.

[aj0strow]

Ah true! Thanks @tgriesser.

[gregbty]

This works fine with the migrations API but the seed API doesn't seem to adhere to the destroy call. If I try knex.migration.latest alone with knex.destroy it works fine, but knex.seed.run does not.

var instance = knex(db);

return instance.migrate.latest()
  .finally(function () {
      return instance.destroy(); //works
    });

...

return instance.seed.run()
  .finally(function () {
      return instance.destroy(); //does not work
    });

[the-dr-lazy]

The issue exists as mentioned in #55 (comment). Are there any workarounds?

[elhigu]

@thebrodmann Please open bug report, this issue was closed, because it was about different thing.