Follow-up for the discussion in <a href="https://github.com/knative/serving/pull/14134

It is in <a href="https://github.com/knative/serving/blob/main/pkg/apis/serving/v1/rev

Here is the defaulting K8s does for all probe types: <a href="https://github.com/kuber

I created a separate issue for <a class="issue-link js-issue-link" data-error-text="Fa

GRPC probes service field should have defaulting about serving HOT 3 CLOSED

ReToCode commented on June 12, 2024

GRPC probes service field should have defaulting

from serving.

ReToCode commented on June 12, 2024

It is in revision_defaults.go, but somehow I still see this error from the webhook, so digging a bit more.

from serving.

skonto commented on June 12, 2024

Here is the defaulting K8s does for all probe types: https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/v1/zz_generated.defaults.go#L256-L290
Should we do the same? Afaik without nullable at the CRD level this will fail but K8s seems to have a long history on this issue wrt OpenAPI conformance.

from serving.

ReToCode commented on June 12, 2024

I created a separate issue for #14771 (comment) -> #14774

from serving.