Coder Social home page Coder Social logo

Comments (5)

helloxjade avatar helloxjade commented on June 12, 2024

The error above occurred because I manually added an environment variable in the controller's deployment configuration:

name: WEBHOOK_NAME
value: webhook

but if I don't add it, a different error occurs

kubectl logs controller-8d57675b8-9c4wb -n knative-serving 
panic: The environment variable "WEBHOOK_NAME" is not set.
This should be unique for the webhooks in a namespace
If this is a process running on Kubernetes, then initialize this variable via:
  env:
  - name: WEBHOOK_NAME
    value: webhook


goroutine 1 [running]:
knative.dev/pkg/webhook.NameFromEnv()
	knative.dev/[email protected]/webhook/env.go:56 +0x7b
main.main()
	knative.dev/serving/cmd/webhook/main.go:166 +0x6f
```
`

from serving.

ReToCode avatar ReToCode commented on June 12, 2024

There is definitely something off with either your setup or your YAML. Our resources contain that env variable: https://github.com/knative/serving/blob/main/config/core/deployments/webhook.yaml#L77.

Please check if your yaml is correct, like get it from

https://knative.dev/docs/install/yaml-install/serving/install-serving-with-yaml/#install-the-knative-serving-component

from serving.

helloxjade avatar helloxjade commented on June 12, 2024

There is definitely something off with either your setup or your YAML. Our resources contain that env variable: https://github.com/knative/serving/blob/main/config/core/deployments/webhook.yaml#L77.

Please check if your yaml is correct, like get it from

https://knative.dev/docs/install/yaml-install/serving/install-serving-with-yaml/#install-the-knative-serving-component

yeah I use Knative Version: 1.11.6 yaml , it dosenโ€˜t have env:

  • name: WEBHOOK_NAME
    value: webhook

from serving.

dprotaso avatar dprotaso commented on June 12, 2024

In 1.11.6 release yaml we have

- name: WEBHOOK_PORT
  value: "8443"

yours is indicating "tcp://10.96.3.39:9090" - which looks like a custom modification you made yourself.

from serving.

dprotaso avatar dprotaso commented on June 12, 2024

I just tested this patch release on kind and the webhooks installed correctly.

from serving.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.