Comments (7)
IDK if we need codegen, I think it's going to literally be the same file in every case. I think the only piece that varies is the stuff in servingv1alpha1
(or equivalent).
I think @n3wscott had half of this initially and I'd recommended removing it, but I am coming around to the logic.
I'm a little concerned that the type aliasing will cause us to need casts for this to work, have you tried it?
from pkg.
I think @n3wscott had half of this initially and I'd recommended removing it, but I am coming around to the logic.
I did! :D
Instead of this:
duckv1alpha1.Condition{
Type: v1alpha1.RouteConditionAllTrafficAssigned,
Status: corev1.ConditionUnknown,
Reason: "RevisionMissing",
Message: `Configuration "not-ready" is waiting for a Revision to become ready.`,
}
How would this feel:
duckv1alpha1.NewCondition( v1alpha1.RouteConditionAllTrafficAssigned).MarkUnknown(
"RevisionMissing",
"Configuration %q is waiting for a Revision to become ready.",
notReady)
And we do not alias the corev1
status types, we just add the mark methods to the Condition
type.
Further, we could move NewCondition
to duck
and have it default to a version for Condition
(for now it will be v1alpha1
)
i.e.
Unknown:
duck.NewCondition( v1alpha1.RouteConditionAllTrafficAssigned).MarkUnknown(
"RevisionMissing",
"Configuration %q is waiting for a Revision to become ready.",
notReady)
Ready:
duck.NewCondition( v1alpha1.RouteConditionAllTrafficAssigned).MarkReady()
Or not mark, maybe just:
Ready()
Unknown(reason, msg, a...)
Failed(reason, msg, a...)
from pkg.
from pkg.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen
. Mark the issue as
fresh by adding the comment /remove-lifecycle stale
.
from pkg.
If y'all still want this, we should do something about it. Otherwise /close
?
from pkg.
Wow forgot about this
from pkg.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen
. Mark the issue as
fresh by adding the comment /remove-lifecycle stale
.
from pkg.
Related Issues (20)
- Downstream Tekton failures HOT 3
- Feature: Generic admission webhook HOT 4
- Identical version referenced in status.ConvertTo HOT 6
- Consider putting the admission review on the webhook context HOT 11
- kmeta package: ChildName function produces invalid resource names HOT 1
- Allow reconcilers to listen to leader promotion events HOT 3
- reconcilerImpl.updateStatus method performance impacted by state difference calculation used in debug mode only
- Make ZipkinTracingEnabled flag thread safe HOT 1
- Support creating TLS servers with mutual trust HOT 2
- Eventing TLS: Update Addressable and AddressStatus HOT 2
- Eventing TLS: Update Destination and KReference HOT 2
- Eventing TLS: Add AddressableFromDestination method on the resolver HOT 2
- Kubernetes 1.26/1.27 support HOT 7
- Drop use of https://github.com/gorilla/websocket HOT 2
- Eventing TLS: Add SinkCACerts to SourceStatus HOT 1
- Bump Min K8s version to 1.25
- Drop dynamic wrapped client generation HOT 8
- Eventing TLS: validate that `Destination.CACerts` is a PEM encoded cert HOT 2
- Drop and turn off QPS and Burst setting HOT 5
- Third party libraries are not latest version HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pkg.