Comments (5)
Sure, just assign the issue to you and go ahead.
from pkg.
@creydr:
This request has been marked as suitable for new contributors.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue
command.
In response to this:
As the Eventing OIDC feature track describes, the
Destination
type allows to reference Addressable resources, raw Kubernetes services or absolute URLs. As for Addressables, it is necessary to additionally specify the required audience for those services.Therefor the
Destination
type needs to allow to additionally specify the destinationsAudience
:type Destination struct { ... // Audience is the OIDC audience. // This need only be set, if the target is not an Addressable // and thus the Audience can't be received from the Addressable itself. // In case the Addressable specifies an Audience too, the Destinations // Audience takes preference. // +optional Audience *string `json:"audience,omitempty"` }
Additional context (optional)
/good-first-issue
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from pkg.
I would like to work on it!
from pkg.
Hi @abhijeetgauravm,
Glad to hear you want to contribute. I am currently creating the tasks for the OIDC implementation in Knative Eventing.
Just a side note: Not all of the created issues might contain all the needed information right now or might be reworked and need to be triaged (that's the reason why I marked them as DRAFT or added the kind/TBD
label). But this issue looks fine I guess.
from pkg.
Can I fix it?
from pkg.
Related Issues (20)
- Eventing TLS: validate that `Destination.CACerts` is a PEM encoded cert HOT 2
- Drop and turn off QPS and Burst setting HOT 5
- Third party libraries are not latest version HOT 11
- Make Knative Health Ports Configureable HOT 2
- What's the difference between *-work_queue_depth and *-workqueue_depth metrics? HOT 1
- Add `Audience` field in `duckv1.Addressable` HOT 4
- Rewrite the Knative code-gen to a Go-native tool HOT 5
- Drop mako code and dependency HOT 5
- Bump our min k8s version to v1.26
- Using patch to set finalizers might lead to having reconciled resources that are never finalized HOT 16
- Eventing TLS: prioritize destination CA certs over resolved addressable CA certs HOT 2
- Storage Version Migrator doing empty patches for no reason HOT 1
- Disable HTTP/2 for webhooks until a fix come HOT 4
- Using filteredInformers with more than one label causes to filters with the wrong LabelSelector
- Bump K8s min version to v1.27
- Migrate to new K8s generator scripts/go commands HOT 2
- Bump our min k8s version to v1.28
- Stop using global variables in favor of context. HOT 6
- TestNamespaceStream is flakey
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pkg.