Coder Social home page Coder Social logo

Comments (5)

creydr avatar creydr commented on August 21, 2024 1

Sure, just assign the issue to you and go ahead.

from pkg.

knative-prow avatar knative-prow commented on August 21, 2024

@creydr:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

As the Eventing OIDC feature track describes, the Destination type allows to reference Addressable resources, raw Kubernetes services or absolute URLs. As for Addressables, it is necessary to additionally specify the required audience for those services.

Therefor the Destination type needs to allow to additionally specify the destinations Audience:

type Destination struct {

 ...

  // Audience is the OIDC audience. 
 // This need only be set, if the target is not an Addressable 
 // and thus the Audience can't be received from the Addressable itself.
 // In case the Addressable specifies an Audience too, the Destinations
 // Audience takes preference.
 // +optional
  Audience *string `json:"audience,omitempty"`
}

Additional context (optional)

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from pkg.

abhijeetgauravm avatar abhijeetgauravm commented on August 21, 2024

I would like to work on it!

from pkg.

creydr avatar creydr commented on August 21, 2024

Hi @abhijeetgauravm,
Glad to hear you want to contribute. I am currently creating the tasks for the OIDC implementation in Knative Eventing.
Just a side note: Not all of the created issues might contain all the needed information right now or might be reworked and need to be triaged (that's the reason why I marked them as DRAFT or added the kind/TBD label). But this issue looks fine I guess.

from pkg.

abhijeetgauravm avatar abhijeetgauravm commented on August 21, 2024

Can I fix it?

from pkg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.