Coder Social home page Coder Social logo

Comments (78)

ppiecuch avatar ppiecuch commented on June 23, 2024

I have my fork of QtnProperty that does not require a separate building -
you only need to include "QtnProperty.pri" in AwesomeBump.pro - I will
include this as a submodule later with linux binaries of PEG tool.

Regards
Pawel

On Tue, Jan 12, 2016 at 11:52 PM, Krzysztof Kolasinski <
[email protected]> wrote:

Assigned #71 #71 to
@ppiecuch https://github.com/ppiecuch.


Reply to this email directly or view it on GitHub
#71 (comment).

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

I'd be happy to work to keep this new development compatible with the cmake builds. I'll add those two libraries as requirements and get it working. Which branch will be used for this effort?

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

master branch :P

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

Ha ha, ok. I'll dig into it.

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

One thought though. Instead of tweaking the base library and having to do multiple compile passes, can't you just override the classes that need to be changed in the default QtnProperty libraries? I think that would be a better approach. Of course knowing nothing about the library or the changes that need to be made, maybe it's easier/better to do it this way. Just wanted to make that suggestion.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

I had a conversation with author of the library, he said that will update his code to fulfil my requirements, so maybe in future there will be no needs to modify the source code.

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

To me this would be all the more reason to adopt an inheritance model and overriding the necessary classes. It would make reverting your code easier in the future when the base library is updated because you could just drop your inherited classes and replace them with the default ones. Further, if the original author doesn't change it in all the ways you need you'll have to modify the base code again. It'll also be harder to maintain your version of that library while including new changes from the base version in the future. I think being able to inherit and override classes is one of the most powerful features of object oriented languages for these types of reasons. However, I'm fine with either approach but just wanted to mention it so you'd at least have it in your mind.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

You are right, but lets, wait for the QtnProperty update, then we can do as you said. I don't know what exactly he is going to change, so it will be better to wait till this moment. I'm going to update today more properties in the left panel.

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

Ok, sounds like a plan. I'll try to get rolling on keeping the cmake compatibility soon.

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

Hi All

I would like to integrate with AB (as a submodule) my fork of qtproperty:
https://github.com/ppiecuch/QtnProperty

My fork is self-contained: you can only include
https://github.com/ppiecuch/QtnProperty/blob/master/QtnProperty.pri
in .pro file - no separate compilation is necessary.

I think it is quite easy to convert QtnProperty.pri into cmake file.

I will include in my repo PEG tools for win/linux/osx (currently only OS X
is available - linux is on its way).

Btw: my fork is always up-to-date with upstream repo.

Regards
Pawel

On Wed, Jan 13, 2016 at 1:59 PM, Krzysztof Kolasinski <
[email protected]> wrote:

I had a conversation with author of the library, he said that will update
his code to fulfil my requirements, so maybe in future there will be no
needs to modify the source code.


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Thanks,
So in that case all the changes in QtnProperty will happen on your fork?

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

Yes - I am heavy user of this library - it is always up to date + I am
working on some extensions like some custom-types, keyboard shortcuts etc.

Regards
P.

On Wed, Jan 13, 2016 at 4:07 PM, Krzysztof Kolasinski <
[email protected]> wrote:

Thanks,
So in that case all the changes in QtnProperty will happen on your fork?


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Ok!
I decided that it will be better to keep all properties like in your example, mixing normal buttons with QtnProperty will demand a lot of work, and will be hard to add some extensions in future.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Could you remove qtnproperty submodule from my repo and replace by yours?

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

replaced

P.

On Wed, Jan 13, 2016 at 4:19 PM, Krzysztof Kolasinski <
[email protected]> wrote:

Could you remove qtnproperty submodule from my repo and replace by yours?


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Ok, thanks.
I need an advice, putting everything to QtnProperty will require huge amount of work, basically I started to write new class - images container. I don't see any better solution for now, by better I mean easier to implement.
So since I have to write new container for images and textures maybe this is a good point to start thinking about background rendering of textures... I have to rewrite at least half of the code :/

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

I have to think about this, otherwise it will take months to make it work... It will be much easier if tabs will stay as they are, so logic will be the same only parameters management will be different

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

For me tabs are ok - it is the content of tabs, that is the problem. In my
opinion, cleanup the content is important. Also, we may later replace tabs
with stacked widget + combobox for selection (like I did in my fork) - it
solves the problem of too many tabs displayed on the screen.

Regards
P.

On Wed, Jan 13, 2016 at 5:10 PM, Krzysztof Kolasinski <
[email protected]> wrote:

I have to think about this, otherwise it will take months to make it
work... It will be much easier if tabs will stay as they are, so logic will
be the same only parameters management will be different


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

@ppiecuch, I'm trying to compile the Core submodule you included in your commit 2f11c52 but I'm getting errors on both the CLI (with cmake and/or gnu compilers directly) and also with QT Creator. It seems that there are some variables that are not declared:

[  9%] Building CXX object CMakeFiles/QtnPropertyCore.dir/PropertyBase.cpp.o
/home/CodePhase/code/AwesomeBump/Sources/utils/QtnProperty/Core/PropertyBase.cpp: In function ‘void qtnScriptRegisterPropertyTypes(QScriptEngine*)’:
/home/CodePhase/code/AwesomeBump/Sources/utils/QtnProperty/Core/PropertyBase.cpp:72:37: error: ‘qtnPropertyIdToScriptValue’ was not declared in this scope
     qScriptRegisterMetaType(engine, qtnPropertyIdToScriptValue, qtnPropertyIdFrom
                                     ^
/home/CodePhase/code/AwesomeBump/Sources/utils/QtnProperty/Core/PropertyBase.cpp:72:65: error: ‘qtnPropertyIdFromScriptValue’ was not declared in this scope
     qScriptRegisterMetaType(engine, qtnPropertyIdToScriptValue, qtnPropertyIdFrom
                                                                 ^
/home/CodePhase/code/AwesomeBump/Sources/utils/QtnProperty/Core/PropertyBase.cpp:73:37: error: ‘qtnPropertyStateToScriptValue’ was not declared in this scope
     qScriptRegisterMetaType(engine, qtnPropertyStateToScriptValue, qtnPropertySta
                                     ^
/home/CodePhase/code/AwesomeBump/Sources/utils/QtnProperty/Core/PropertyBase.cpp:73:68: error: ‘qtnPropertyStateFromScriptValue’ was not declared in this scope
     qScriptRegisterMetaType(engine, qtnPropertyStateToScriptValue, qtnPropertySta
                                                                    ^
CMakeFiles/QtnPropertyCore.dir/build.make:62: recipe for target 'CMakeFiles/QtnPropertyCore.dir/PropertyBase.cpp.o' failed
make[2]: *** [CMakeFiles/QtnPropertyCore.dir/PropertyBase.cpp.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/QtnPropertyCore.dir/all' failed
make[1]: *** [CMakeFiles/QtnPropertyCore.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

Is there a specific library I need to install to get this to work? I have QT Strings, Core, GUI, etc already installed. Are these undefined variables specific to your code? I tried Google to find if they were part of another library but had no success.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Did you try to compile oryginal library?

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

Hi

No - library is self-contained. I am just building linux binaries right now
and will commit all changes tomorrow.

Regards
Pawel

On Wed, Jan 13, 2016 at 8:32 PM, CodePhase [email protected] wrote:

@ppiecuch https://github.com/ppiecuch, I'm trying to compile the Core
submodule you included in your commit 2f11c52
2f11c52
but I'm getting errors on both the CLI (with cmake and/or gnu compilers
directly) and also with QT Creator. It seems that there are some variables
that are not declared:

[ 9%] Building CXX object CMakeFiles/QtnPropertyCore.dir/PropertyBase.cpp.o
/home/CodePhase/code/AwesomeBump/Sources/utils/QtnProperty/Core/PropertyBase.cpp: In function ‘void qtnScriptRegisterPropertyTypes(QScriptEngine_)’:
/home/CodePhase/code/AwesomeBump/Sources/utils/QtnProperty/Core/PropertyBase.cpp:72:37: error: ‘qtnPropertyIdToScriptValue’ was not declared in this scope
qScriptRegisterMetaType(engine, qtnPropertyIdToScriptValue, qtnPropertyIdFrom
^
/home/CodePhase/code/AwesomeBump/Sources/utils/QtnProperty/Core/PropertyBase.cpp:72:65: error: ‘qtnPropertyIdFromScriptValue’ was not declared in this scope
qScriptRegisterMetaType(engine, qtnPropertyIdToScriptValue, qtnPropertyIdFrom
^
/home/CodePhase/code/AwesomeBump/Sources/utils/QtnProperty/Core/PropertyBase.cpp:73:37: error: ‘qtnPropertyStateToScriptValue’ was not declared in this scope
qScriptRegisterMetaType(engine, qtnPropertyStateToScriptValue, qtnPropertySta
^
/home/CodePhase/code/AwesomeBump/Sources/utils/QtnProperty/Core/PropertyBase.cpp:73:68: error: ‘qtnPropertyStateFromScriptValue’ was not declared in this scope
qScriptRegisterMetaType(engine, qtnPropertyStateToScriptValue, qtnPropertySta
^
CMakeFiles/QtnPropertyCore.dir/build.make:62: recipe for target 'CMakeFiles/QtnPropertyCore.dir/PropertyBase.cpp.o' failed
make[2]: *_* [CMakeFiles/QtnPropertyCore.dir/PropertyBase.cpp.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/QtnPropertyCore.dir/all' failed
make[1]: *** [CMakeFiles/QtnPropertyCore.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

Is there a specific library I need to install to get this to work? I have
QT Strings, Core, GUI, etc already installed. Are these undefined variables
specific to your code? I tried Google to find if they were part of another
library but had no success.


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

Yes, I tried your original @kmkolasinski and was able to get that to compile. Thanks for looking at it @ppiecuch. I probably should have mentioned I'm using Linux as my platform.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

For me it seems to be problem related to include paths, since compilator does not see declarations for classes which actually are in the same project.

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

Could be, but I'm not sure. I did a search on all instances of the variable qtnPropertyIdToScriptValue and couldn't find the declaration statement (or any other instance of that variable name) anywhere in the code base, other than where the compile error occurred: https://github.com/ppiecuch/QtnProperty/blob/abcd02e4cd33124e92032f1c70871f957d626a56/Core/PropertyBase.cpp#L72. You guys are smart though so I'm sure you'll figure it out :-)

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

Opps, wrong button. Didn't mean to close this.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Wow, I don't have this in my code, maybe this appear because of the @ppiecuch modification of the library?

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

Could be, not sure. It probably works on his system but I think he's on Mac so my system probably doesn't have the same native configuration. He says it's monolithic so it should not depend on anything. I'm sure he'll be able to work it out soon though.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Yes that is for sure :) did you managed to run my last commit? and tested the custom fragment shader feature?

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

I got the cmake portion finished for both the Core and PEG components done but then we replaced your submodule with the new one. Sorry, never got to finish so I didn't preview it. I'm looking forward to it though! Once we get this issue worked out I think I should be able to get it working with cmake pretty soon afterwards so I can check it out.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Ok, don't worry I have a lot of work with migration to QtnProperty, very boring job ;)

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

ha ha well if I knew anything about it I'd help you.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

No, it has to be done by one person, otherwise we will die during the merging process, the work cannot be just simply divided.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

I've read your answer too fast, I just realized what you wrote ;) Forget it my previous comment.

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

Currently I am on linux - for these fixes only :)

P.

On Wed, Jan 13, 2016 at 9:16 PM, CodePhase [email protected] wrote:

Could be, not sure. It probably works on his system but I think he's on
Mac so my system probably doesn't have the same native configuration. He
says it's monolithic so it should not depend on anything. I'm sure he'll be
able to work it out soon though.


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

For me it is evident that It would be nice to have new delegate for color picking, instead of opening color dialog it will send special signal, which will be treated in program. It would be also nice to have possibility to have property which behaves like button. Then I think it would be possible to port all the controls to QtnProperty. @ppiecuch would it be possible to write such special delegates for properties?

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

Yep - possible; I have started with button property (I called it Action). I
will try to put some placeholders for these in the library tomorrow.

Regards
P.

On Wed, Jan 13, 2016 at 10:50 PM, Krzysztof Kolasinski <
[email protected]> wrote:

For me it is evident that It would be nice to have new delegate for color
picking, instead of opening color dialog it will send special signal, which
will be treated in program. It would be also nice to have possibility to
have property which behaves like button. Then I think it would be possible
to port all the controls to QtnProperty. @ppiecuch
https://github.com/ppiecuch would it be possible to write such special
delegates for properties?


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

lexxmark avatar lexxmark commented on June 23, 2024

Hi guys,

I'm developer of the QtnProperty and I'm very glad you decided to use my library.
I wanna help you and adopt QtnProperty to all your needs. I agree that it will be better to include original library as submodule to your project.

So from my side I will modify QtnProperty to be more customazible and flexible. On your side we will write custom delegates that are specific for your project.

A few days ago I started customize look&feel of QtnPropertyView. See PropertyView.h line 103 where declared set of methods that you can override to change non-delegates appearance (properties names, backgrounds, grid lines etc). Just derive your class from QtnPropertyView and override any virtual method.

My next main task is make delegate's interface more "interactive". I'm going to add handling mouse and keyboard events there, so delegates will be able respond to mouse moves/drugs/clicks. Now there is the only possibility for delegate is to create inplace editor activated by mouse click or dbl-click.

Another problem is the way I register delegates. If you use QtnProperty project as static library the registration may not be called. So I suggest to have some initialization function (like initializeQtnPropertyLib(); ) that will do all the registrations and clients should call it before using QtnProperty library.

@ppiecuch I saw your fork of QtnProperty and I think we should merge some useful modifications to main repo.

So guys, feel free to open issues and discussions in QtnProject to better utilize it.

Regards,
Alex

P.S.
I'm also very interesting in developing custom delegates for your project.
And sorry I'm in different time zone, so expect delays in my replies.

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

Hi Alex - nice to meet you - at first QtnProperty is a very solid piece of
work - congrats!

I have one problem that is bother me recently: we have several pef files:

PEG_SOURCES += properties/Filter3DDOF.pef \

           properties/Filter3DBloom.pef \

           properties/Filter3DLensFlares.pef \

           properties/Filter3DToneMapping.pef \

           properties/GLSLParsedFragShader.pef \

           properties/ImageProperties.pef \

           properties/Filters3D.pef

but .h files created from these are not preprocessed with moc. Have you
ever seen such a problem?

Regards
Pawel

On Thu, Jan 14, 2016 at 9:03 AM, Alex Zhondin [email protected]
wrote:

Hi guys,

I'm developer of the QtnProperty and I'm very glad you decided to use my
library.
I wanna help you and adopt QtnProperty to all your needs. I agree that it
will be better to include original library as submodule to your project.

So from my side I will modify QtnProperty to be more customazible and
flexible. On your side we will write custom delegates that are specific for
your project.

A few days ago I started customize look&feel of QtnPropertyView. See PropertyView.h
line 103
https://github.com/lexxmark/QtnProperty/blob/master/PropertyWidget/PropertyView.h#L103
where declared set of methods that you can override to change non-delegates
appearance (properties names, backgrounds, grid lines etc). Just derive
your class from QtnPropertyView and override any virtual method.

My next main task is make delegate's interface more "interactive". I'm
going to add handling mouse and keyboard events there, so delegates will be
able respond to mouse moves/drugs/clicks. Now there is the only possibility
for delegate is to create inplace editor activated by mouse click or
dbl-click.

Another problem is the way I register delegates. If you use QtnProperty
project as static library the registration may not be called. So I suggest
to have some initialization function (like initializeQtnPropertyLib(); )
that will do all the registrations and clients should call it before using
QtnProperty library.

@ppiecuch https://github.com/ppiecuch I saw your fork of QtnProperty
and I think we should merge some useful modifications to main repo.

So guys, feel free to open issues and discussions in QtnProject to better
utilize it.

Regards,
Alex

P.S.
I'm also very interesting in developing custom delegates for your project.
And sorry I'm in different time zone, so expect delays in my replies.


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

lexxmark avatar lexxmark commented on June 23, 2024

Hi Pawel,

Yes I faced this problem too. Now I just re-run qmake and build again. But it's just workaround.
I think it's because qmake system sometimes doesn't take into account that output of PEG tool is input for MOC tool.

I tried many variants to fix it but unsuccessfully. I will try again and may be ask at Qt forums.
I hope CMake tool has explicit dependency rules and there is no such issues there.

Alex

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

I'm actually working to integrate cmake with this. It seems like I've got Core and PEG working with cmake, but am still working on Tests and haven't touched PropertyWidget or Demo yet . Not sure how to handle the PEG files (pef) for Tests and I just started doing the research.

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

@lexxmark: this problem happened when moc output was same as obj output; now I output mic files into separate directory and all seems to be working fine.

Seems like I have finally managed to integrate my fork of QtnProperty - on linux and mac AB build ok. I have modified AwesomeBump.pro with all necessary changes. I have also tried to somehow cleanup building process:

  1. objects files are generated into directory workdir/$$SPEC-[debug]-[gl4], e.g: workdir/macx-clang-dgb-gl4 into subdirectories bin/moc/obj
  2. because there is worker/ subdirectory, it is enough to call qmake in root directory - AwesomeBump.pro is checking this condition (make Source/AwesomeBump.pro)

QtnProperty now contains binaries for linux and mac - however they depends on QtCore library. If QtnPEG is not working on your system, you can rebuild it with: qmake Property.pro in QtnProperty top directory.

Regards
P.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Thanks for collaboration, I will try your changes new week.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Hi,
@ppiecuch could you prepare for me QtnProperty delegates for Button or Action as you said, and for Color picker. Having those properties I would be able to migrate all the features easily. I will push my changes when all the problems with compilation and dependencies will be solved.
Best regards,
K

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

Hi - working on this. I am waiting for some recommendation from QtnProp
author to avoid some double work. Anyway I will try to commit something
today/tomorrow.

P.

On Fri, Jan 15, 2016 at 11:16 AM, Krzysztof Kolasinski <
[email protected]> wrote:

Hi,
@ppiecuch https://github.com/ppiecuch could you prepare for me
QtnProperty delegates for Button or Action as you said, and for Color
picker. Having those properties I would be able to migrate all the features
easily. I will push my changes when all the problems with compilation and
dependencies will be solved.
Best regards,
K


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

Hi - as for the QColor: you want to have an option to replace standard
color picker with your own dialog? This is a change you would like to have ?

As for Action property: I propose something like this:

QAction QActionPropertyExample

{

    description = "This is a button.";

    slot propertyDidChange

    {

        qDebug() << Q_FUNC_INFO << "Button clicked" << this;

    }

}

Regards
P.

On Wed, Jan 13, 2016 at 10:50 PM, Krzysztof Kolasinski <
[email protected]> wrote:

For me it is evident that It would be nice to have new delegate for color
picking, instead of opening color dialog it will send special signal, which
will be treated in program. It would be also nice to have possibility to
have property which behaves like button. Then I think it would be possible
to port all the controls to QtnProperty. @ppiecuch
https://github.com/ppiecuch would it be possible to write such special
delegates for properties?


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Hi, sorry for late answer, regarding the QColor I was thinking about something similar to current solution, you press the button, then after you choose the color from image it will change color to selected one. I think it could be done with QAction button, which would allow for background color manipulation.

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

Hello-but selection should be made on some custom color-selection panel?
That's the difference?

Regards
Pawel

On Mon, Jan 18, 2016 at 10:32 AM, Krzysztof Kolasinski <
[email protected]> wrote:

Hi, sorry for late answer, regarding the QColor I was thinking about
something similar to current solution, you press the button, then after you
choose the color from image it will change color to selected one. I think
it could be done with QAction button, which would allow for background
color manipulation.


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

No, without any selection panel or dialog. Currently picking is done with QButton object which changes color after pixel selection, I would prefer to stay with this solution.

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

Hi
I have added button delegate for any Bool property - creating a button can
be done like this:

Bool BoolButtonProperty

{

    description = "Property with button delegate.";

    value = false;

    delegate Button

    {

    title = "Button title";

    }

    slot propertyDidChange

    {

        qDebug() << Q_FUNC_INFO << "Poperty has changed: " << this;

    }

}

Currently Button has one property "title". For now rendering is done in one
column, but goal is to have it span over two columns (without Prop name
column). Also selection has to be fixed.

[image: Inline image 1]

As for the color: I can add an option to remove selection with dialog and
add expanded R,G,B properties:

QColorProperty | [] #00ff80
------------------+-----------
Red | 00
------------------+-----------
Green | ff
------------------+-----------
Blue | 80
------------------+-----------

Regards
Pawel

On Mon, Jan 18, 2016 at 11:21 AM, Krzysztof Kolasinski <
[email protected]> wrote:

No, without any selection panel or dialog. Currently picking is done with
QButton object which changes color after pixel selection, I would prefer to
stay with this solution.


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Hi, thanks for that, I will try to implement those buttons in few days, since currently I'm quite busy.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Ok, I pushed quite large commit, still many things is not implemented, float property does not work since there is no finishEditing signal in your QtnProperty fork now. @lexxmark when we can expect the hot property editing avaiable in your library? :)

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

Sounds cool :) "Dobra zmiana"
Here is my latest commit:

[image: Inline image 1]

P.

On Mon, Jan 18, 2016 at 9:59 PM, Krzysztof Kolasinski <
[email protected]> wrote:

Ok, I pushed quite large commit, still many things is not implemented,
float property does not work since there is no finishEditing signal in your
QtnProperty fork now. @lexxmark https://github.com/lexxmark when we can
expect the hot property editing avaiable in your library? :)


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

I don't see any images.

from awesomebump.

ppiecuch avatar ppiecuch commented on June 23, 2024

[image: Inline image 1]

On Mon, Jan 18, 2016 at 10:40 PM, Krzysztof Kolasinski <
[email protected]> wrote:

I don't see any images.


Reply to this email directly or view it on GitHub
#71 (comment)
.

More:

(http://komsoft.ath.cx/ http://komsoft.ath.cx/spider.html)
(http://pawelp.ath.cx/ http://komsoft.ath.cx/spider.html)

from awesomebump.

lexxmark avatar lexxmark commented on June 23, 2024

@kmkolasinski
I'm working on hot editing now. First draft is ready. See my comments here

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Ok, so I moved almost everything to QtnProperty. Just did a commit with my changes. Now I will wait for the of changing Float and Int or Double with mouse like horizontal scrollBar. Currently when you have to change parameter with keyboard or mouse wheel is very annoying, in my opinion. Since user does not know where is the min and max value.

from awesomebump.

lexxmark avatar lexxmark commented on June 23, 2024

@kmkolasinski please see answer here

from awesomebump.

brothermechanic avatar brothermechanic commented on June 23, 2024

Hello
I want to try your programm but i have a building problem
$ git clone --recursive https://github.com/kmkolasinski/AwesomeBump.git
$ cd AwesomeBump/Sources
$ /usr/lib64/qt5/bin/qmake
$ make
build log http://www.pasteall.org/63816
Please help me to compile

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Hi, did you try to build it with QtCreator? and do you really want to work with this unstable version?

from awesomebump.

brothermechanic avatar brothermechanic commented on June 23, 2024

No, i don't. But do it matter?
The latest release is very old. Yes, it will be cool to see latest git version.

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

It should not, however I have sometimes problems with linker during compilation using Qt Creator, which seems to be similar to your. Then after I click "run qmake" in GUI then everything compiles and program runs. Additionally I'm not used to compile AB from command line, other people are doing this, so they can help you.
There were not significant changes since last release, so I would suggest you to try the old one, if you just want to use AB. Current master contains significant changes in GUI nothing else.

from awesomebump.

brothermechanic avatar brothermechanic commented on June 23, 2024

Ok! I will use release version for now.
Thank you for reply!

from awesomebump.

brothermechanic avatar brothermechanic commented on June 23, 2024

Hello, agane
I susses compile 4.0.0, but have segfault

[456841.031079] AwesomeBump[14270]: segfault at 0 ip 00000000004186d9 sp 00007ffe0e71c700 error 4 in AwesomeBump[400000+28f000]
[456848.519756] AwesomeBump[14282]: segfault at 0 ip 00000000004186d9 sp 00007fff2d9d1850 error 4 in AwesomeBump[400000+28f000]

$ AwesomeBump.sh
QIODevice::write (QFile, "log.txt"): device not open
/usr/bin/AwesomeBump.sh: line 4: 14338 Segmentation fault ./AwesomeBump

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Check your read write permissions:

QIODevice::write (QFile, "log.txt"): device not open

It is very strange that even log.txt does not want to be created.
Did you try to use binary package?

from awesomebump.

brothermechanic avatar brothermechanic commented on June 23, 2024

Now i build master git commit f6ac321
And AwesomeBump works! (Not much tested yet)
ps: But there is another issue!)

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Great! What kind of issue?

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

@lexxmark After your last commit AB crashes during initialization with assert:

ASSERT: "jt != createItem.createFunctions.end()" in file ../AwesomeBump/Sources/utils/QtnProperty/PropertyWidget/Delegates/PropertyDelegateFactory.cpp, line 51
The program has unexpectedly finished.

Yesterday, I had no problem with it. I commited current version of source code.

from awesomebump.

lexxmark avatar lexxmark commented on June 23, 2024

@kmkolasinski - You should call void regABSliderFloatDelegate(); somewhere in your code.
Just uncomment some lines in main.cpp

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

I'm not using the ABSlider anymore, so I commented the regABSliderFloatDelegate function.
Note that ABSlider is no more in use: ImageProperties.pef

from awesomebump.

lexxmark avatar lexxmark commented on June 23, 2024

You are using it later here and in two more places :o).

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Oh sorry, a bad day :/ I completely forgot about these guys :( I will fix it tomorrow. Thanks!

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Ok, shame on me! Now, it works :)
I will spend few days to finish slider then I will play with Buttons and Colors.
However I have question: Where this is done in code?

grab  0x0  -  0xece0030
release  0xece0030  -  0xece0030

It should be commented :)

from awesomebump.

lexxmark avatar lexxmark commented on June 23, 2024

grab 0x0 - 0xece0030
release 0xece0030 - 0xece0030

Well I don't see this debug output in my last master commit.
Anyway I've cleaned up the code and will commit soon.

Also @kmkolasinski and @ppiecuch - we can create hybrid delegate factory function for Button which will create Link delegate undex OSX and Button delegate otherwise.

I must remind that I'm doing some files reorganizations in QtnProperty so excuse me for possible compile errors in your code (missing includes).

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Hmm, maybe it is in AwesomeBump source, but I did not write this... I will search for this in my code later.
For me simple button is OK.

from awesomebump.

lexxmark avatar lexxmark commented on June 23, 2024

Hmm, maybe it is in AwesomeBump source, but I did not write this

Actually I did it but removed in last master commit

from awesomebump.

PoULkY avatar PoULkY commented on June 23, 2024

hello
I already clone this repo but when git cloning QtnProperty, it comes error

fatal: reference is not a tree: d7140711e148ce3259f6817459fdbe6b10b3435d

Unable to checkout 'd7140711e148ce3259f6817459fdbe6b10b3435d' in submodule path 'Sources/utils/QtnProperty'

Is there something wrong ?

from awesomebump.

kmkolasinski avatar kmkolasinski commented on June 23, 2024

Dear all,
finally me and @lexxmark have managed to make QtnPoperty working with AB!
I pushed today a large commit with many changes. Now, I think new GUI should work fine, however for sure there still will be some minor BUGs.
In next step, I will try to fix some other issues reported by users, and during this time it would be nice to have a nice script for AB compilation.

I'm closing this long issue and in case of any problems please set up a new one.

from awesomebump.

CodePhase avatar CodePhase commented on June 23, 2024

Very good news and congratulations! I'll try and find some time for an updated cmake compile script.

from awesomebump.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.