WindSSPhaseScreen: unexpected keyword argument 'use_cached_spectrum' about pyatmosphere

[KlenM]

Hello, thank you for publishing this issue.

I'm not sure about your use case, but it seems that the WindSSPhaseScreen class is now quite redundant.
Using the SSPhaseScreen class and passing the shift values manually will achieve the same result.

For example, if you want to use

phase_screen = WindSSPhaseScreen(wind_speed=WIND_SPEED)
for i in range(100):
    result = phase_screen.generate_phase_screen()

try this

phase_screen = SSPhaseScreen(wind_speed=1)
for t in range(100):
    shift = (t * WIND_SPEED, 0)
    result = phase_screen.generate_phase_screen(shift=shift, wind=True) # wind=True allows some caching optimisation

---

If you still want to use the WindSSPhaseScreen class, try replacing use_cached_spectrum with wind on this line

pyAtmosphere/pyatmosphere/phase_screens.py

Line 151 in 5a5ff2d

return super().generate_phase_screen(shift=shift, use_cached_spectrum=True)

(If you used pip install pyatmosphere, you can change the source code in venv/lib/python3.10/site-packages/pyatmosphere. But make sure you are aware of the possible consequences of this action)

Thanks again for the issue, I'll keep in mind to remove WindSSPhaseScreen in future updates.