$request->params($key, $default = null) for non empty about klein.php

[Rican7]

An "empty" (blank string) parameter is completely legal in HTTP, so I'm not sure how I feel about this.

For example, sending a query parameter with no value still yields a blank/empty value, as compared to a "null" value:

• Example: http://www.example.com/page?query=value&keywithnovalue
• Reference: http://www.php.net/manual/en/reserved.variables.get.php#98419

[Surt]

Yep, you are right. Maybe adding a third parameter, "$on_empty=false"? So if you override it to true it will check for a non blank, null value.

public function param($key, $default = null, $on_empty = false)
    {
        // Get all of our request params
        $params = $this->params();
        return isset($params[$key]) ? ($on_empty && empty($params[$key]))?$default:$params[$key] : $default;
    }

[Rican7]

Yea, you could do that, but having multiple optional params feels a little dirty (sometimes you can't avoid it, though), and stacking ternary's in PHP is never a good idea.

From the PHP.net manual:

Note:

It is recommended that you avoid "stacking" ternary expressions. PHP's behaviour when using more than one ternary operator within a single statement is non-obvious:

[Surt]

Yep, I already changed it. About multiple params.. well, I prefer to have it on the function interface than checking it on my code, each time. Pasted here if someone wants to use it.

public function param($key, $default = null, $on_empty = false)
    {
        // Get all of our request params
        $params = $this->params();
        return ( (!isset($params[$key])) || ($on_empty && empty($params[$key])))?$default:$params[$key];
    }

[Rican7]

Thanks for understanding! And thanks for leaving your code for someone else to run into. :)