Coder Social home page Coder Social logo

Comments (6)

klauspost avatar klauspost commented on June 19, 2024

The reason, as I remember it is, that it basically gives a different result than dcraw. I want to minimize the difference between them, and since it (even at the time I started writing RS) is a very old camera, I just decided to ignore it than spend too much time on it, since Nikon luckily dropped that path of development.

from rawspeed.

pedrocr avatar pedrocr commented on June 19, 2024

The result it gives is what's in the file, a half height image that needs to be scaled up after demosaic. dcraw does that upscale. I don't think rawspeed does any demosaic itself, and if it does, at least darktable certainly doesn't use it, so it's usually up to the app to scale up the image.

rawspeed should definitely provide the app with the metadata it needs to apply the operation. We need to think of an interface to do this as it's also an issue with the fuji cameras that need rotation after demosaic. I suppose adding that info to cameras.xml and providing it through the existing metadata interface would be our best bet.

from rawspeed.

LibRaw avatar LibRaw commented on June 19, 2024

There are a lot of D1X files in archives.
So, generally speaking, it is better to decode it and provide aspect ratio to RawSpeed users.

The same thing with some very old Kodak files (DC50 or DC120, cannot remember). But the image is compressed in horizontal direction.

from rawspeed.

pedrocr avatar pedrocr commented on June 19, 2024

@LibRaw I assume you mean decode the raw data and pass on the metadata on what to do to it after demosaic (2x scale up in this case). That's the only thing you can do when the app wants the raw bayer data and not a RGB image.

from rawspeed.

LibRaw avatar LibRaw commented on June 19, 2024

I agree. The only way to deal with bayer-processing upper layer is to return bayer array as-is and provide aspect ratio data for use after demosaic.

from rawspeed.

klauspost avatar klauspost commented on June 19, 2024

Should be fixed with #49

from rawspeed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.