Comment after JMP at indentation level 0 about asmfmt

[klauspost]

The comment is intended to document what is below. The label is considered "global" and is therefore not indented, and the comment above keeps that indentation. So yes, it is intended.

If you want it indented, it can be moved to after the label

[mmcloughlin]

Why does it move the comment before "done" but not the comment before "loop"?

[mmcloughlin]

I think this is a minimal example of what I'm asking:

$ cat labelcomments.s
#include "textflag.h"

TEXT ·LabelComments(SB), NOSPLIT, $0-32
	XORQ AX, AX
	// A
a:
	JMP b
	// B
b:
	XORQ AX, AX
$ asmfmt labelcomments.s
#include "textflag.h"

TEXT ·LabelComments(SB), NOSPLIT, $0-32
	XORQ AX, AX

	// A
a:
	JMP b

// B
b:
	XORQ AX, AX

[klauspost]

JMP and RET are considered terminators meaning they terminate the block they are in.

Comments are seen as belonging to whatever is following them. Therefore the B is considered as belonging to the b label.

[mmcloughlin]

I know what terminator instructions are. It does not seem right to me that they should affect formatting in this way.

Comments are seen as belonging to whatever is following them.

This seems reasonable. Therefore A should belong to the a label also.

Anyway, seems clear that you intended it to work this way, and we just happen to disagree.