Comments (5)
Is it possible to throw error when limit
is less than scanCount
? I think it would help...
from nestjs-throttler-storage-redis.
If people run into the problem then I will increase it, maybe even allowing a configurable option for it.
from nestjs-throttler-storage-redis.
@kkoomen , thanks for the scanCount
parameter, but it really took me awhile to find the issue. It especially nasty because locally you don't usually test with big limits as @Zippersk mentioned. I believe having an example in readme with full parameter set would be beneficial.
from nestjs-throttler-storage-redis.
@wips This does work right? It has been implemented so I guess I can close this. I totally forgot to close this.
from nestjs-throttler-storage-redis.
@kkoomen , It works, thanks, but in a weird way. For example when I set LIMIT to 1k I need to set scanCount somewhere between 10k and 20k to make it reliably cut-off requests after limit is reached. It happens when I try to load the endpoint at 5-10req/s rate. I assume it has nothing to do with this project, looks like a weird behaviour of ioredis or Redis itself, I don't have much experience with it, so maybe it's expected.
from nestjs-throttler-storage-redis.
Related Issues (20)
- That is a bad idea to use Redis SCAN command, it works not like you expects... HOT 6
- Request flooding bypasses rate limit to some extend HOT 6
- unable to implement custom guard HOT 1
- WRONGTYPE Operation against a key holding the wrong kind of value HOT 8
- Redis storage does is not working - no errors HOT 3
- Wrong `timeToExpire` unit HOT 2
- Dynamically update config values of limiter HOT 1
- Redis connection kept open after application shutdown
- @nestjs/throttler v5 ttl unit changed from second to milisecond HOT 4
- connecting with forRootAsync doesn't work HOT 11
- reflect-metadata ^0.2.1 HOT 3
- fix - redis keyPrefix option is not supported HOT 2
- version issue HOT 1
- Support redis cluster HOT 14
- Issue Fixed in 322 Still Exists HOT 2
- `Maximum call stack size exceeded` error while e2e test my NestJS app HOT 3
- update ioredis to v5
- suggestion: uninstall @types/ioredis
- Update peer dependencies on @nestjs/common and @nestjs/throttler to latest version compatible versions HOT 4
- connect aws ElastiCache with seperate read and write HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nestjs-throttler-storage-redis.