Coder Social home page Coder Social logo

Comments (8)

kelson42 avatar kelson42 commented on June 9, 2024 1

@mgautierfr Looks go to you to publish this project next on org.kiwix.libkiwix on Maven Central and use its own numbering. Starting with current version 1.0.0 and then following dedicated sementic versioning? Does not change primary request of this ticket to properly stick libkiwix .so dependency for releases anyway...

from java-libkiwix.

kelson42 avatar kelson42 commented on June 9, 2024

@MohitMaliFtechiz this is only part of the problem: for releases we should have:

  • A fix dependency to the .so (therefore no permalink)
  • java-libkiwix version name should be the same as libkiwix underlying version name.

The way to implement this is the following: somewhere define the libkiwix version name (in Gradle), for the moment "12.0.0" and based on this variable, do the necessary.

@mgautierfr What wozud be the solution for java-libkiwix version name if we want to re-release but libkiwix has not been upgraded meanwhile?

from java-libkiwix.

mgautierfr avatar mgautierfr commented on June 9, 2024

@mgautierfr What wozud be the solution for java-libkiwix version name if we want to re-release but libkiwix has not been upgraded meanwhile?

Well... I have lost the battle about keeping the wrapper with the library between moving the wrapper in another project independent of the wrapped library. So I would say that you know better than me :)

For a more useful answer: How do we do on python-libzim ?

On top of that, despite of its name, java-libkiwix doesn't wrap libkiwix. It wraps libkiwix and libzim. And they have different versions. What happen if we upgrade libzim but not libkiwix ?

I think the best is to use a specific version for java-libkiwix and do not try to stick to libkiwix or libzim.

from java-libkiwix.

kelson42 avatar kelson42 commented on June 9, 2024

@mgautierfr agree, this is whst we do usually

@MohitMaliFtechiz please delete everything from maven and release s 1.0.0 for libkiwix 12.0.0

from java-libkiwix.

kelson42 avatar kelson42 commented on June 9, 2024

@mgautierfr please check and handle, to me looks like @MohitMaliFtechiz does not understand what is expected and the rationals behind and I don't have the time to check everything myself.

from java-libkiwix.

MohitMaliFtechiz avatar MohitMaliFtechiz commented on June 9, 2024

@MohitMaliFtechiz please delete everything from maven and release s 1.0.0 for libkiwix 12.0.0

@kelson42, We should not delete all the artifacts from maven, because our kiwix-android 3.7.1, 3.7.0, 3.6.0 uses the java-libkiwix 10.1.1, if we delete this version from maven then it will break the compilation for these versions of android. If we have a higher version on the maven then we can not upload an artifact with a lower version.

from java-libkiwix.

kelson42 avatar kelson42 commented on June 9, 2024

If we have a higher version on the maven then we can not upload an artifact with a lower version.

This is exactly why I say to delete everything. Being able to compile older versions is not a strong requirement.

An other approach would be to use this opportunity to upload on proper new repo name: org.kiwix.libkiwix.

from java-libkiwix.

MohitMaliFtechiz avatar MohitMaliFtechiz commented on June 9, 2024

The second approach sounds good.

from java-libkiwix.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.