Coder Social home page Coder Social logo

Comments (2)

csidirop avatar csidirop commented on July 22, 2024 1

Btw. Solving this fixes also following issues:

  • Incorrectly assigned Data Format entries (e.g.: two MODS entries with false paths or entries not in MetadataDefaults.php) (first mentioned in #1147)
  • Calendar overview stopped working / showed nothing (getIssuesFromDocuments() called $document->getYear() but year was false indexed (volume instead of year) and thues there could no calendar get build)
  • Metadata is not translated when you change the language (in PageView)

All those issues are fixed by my proposal. So I'll open a PR and be open for feedback or changes.

Edit: Some of those errors coming from a faulty DFG-Viewer setup slub/dfg-viewer#283

from kitodo-presentation.

csidirop avatar csidirop commented on July 22, 2024

In addition: We could "fix" this by modifying the index_name of the translation. e.g: $translatedRecord->setIndexName($indexName."_".$siteLanguage->getLanguageId()); (here)

But I do not know if this is a good solution or just a workaround. If you think this thats ok, I can prepare a PR.

from kitodo-presentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.