Getting pyshark packets from queue / pickle problems about pyshark

[d6bels]

Thanks, the infinite loop probIem does not occur anymore, but the issue is still not completely solved.
I now have a problem unpickling packets because of :

File "/home/kbleniat/Lab/spymoon/spypy/lib/python2.7/site-packages/pyshark-0.3.4-py2.7.egg/pyshark/packet/layer.py", line 86, in new
print callable(getattr(main_field, "get_default_value"))
AttributeError: 'str' object has no attribute 'get_default_value'

It seems that in LayerFieldsContainer.__new__, the parameter main_field is not always an object having the get_default_value method.

I was able to bypass the problem by checking that it has the method before calling it but it is not a fix in any way.

packet/layer.py

def __new__(cls, main_field, *args, **kwargs):
    if hasattr(main_field, "get_default_value"):  # FIXME
        obj = str.__new__(cls, main_field.get_default_value(), *args, **kwargs)
    else:
        obj = str.__new__(cls, main_field, *args, **kwargs)
    obj.fields = [main_field]
    return obj

[he2ss]

Hello,

I had the same issue as @d6bels and i also patched it in my own code:

from pyshark.packet import layer
class LayerFieldsContainer(layer.LayerFieldsContainer):
    def __new__(cls, main_field, *args, **kwargs):
        if hasattr(main_field, 'get_default_value'):
            obj = str.__new__(cls, main_field.get_default_value(), *args, **kwargs)
        else:
            obj = str.__new__(cls, main_field, *args, **kwargs)
        obj.fields = [main_field]
        return obj
layer.LayerFieldsContainer = LayerFieldsContainer

[KimiNewt]

This is caused by the fact that some of the classes packet uses override getattr. Fixed in 541fc52

[leonisawesome]

I am running into this new now myself.

Latest Mac OS (10.13.6)
Latest Anaconda (4.5.11) with all patches installed