Coder Social home page Coder Social logo

Comments (3)

bbayles avatar bbayles commented on July 21, 2024

@goretkin, could you try my branch? I think this is a good idea.

from pyshark.

goretkin avatar goretkin commented on July 21, 2024

@bbayles thanks! which will return a new-line terminated path, so that needs to be stripped. Also check_output needs to be qualified. Then it works great!

@@ -36,7 +36,7 @@ def get_tshark_path():
     # `which tshark`, common paths.
     else:
         try:
-            which_tshark = check_output(['which', 'tshark']).decode('ascii')
+            which_tshark = subprocess.check_output(['which', 'tshark']).decode('ascii').strip()
         except subprocess.CalledProcessError:
             pass
         else:

from pyshark.

bbayles avatar bbayles commented on July 21, 2024

I like @baszoetekouw's method better than mine - I've replaced my method with his, and added it to #58.

@baszoetekouw and @goretkin, I will merge these on Wednesday morning unless @KimiNewt has some objection.

Thanks!

from pyshark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.