KPM: Extracting plugin_name from jarfile is fragile about killbill-cloud

[sbrossie]

@wwjbatista Re-opening the task. I think you fix 'almost' works, but not for all cases:

> file_path="/Somewhere/xxx-foo/target/xxx-foo-1.0.0.jar"
"xxx-foo"  => GOOD

> file_path="/Somewhere/xxx-foo/target/xxx-foo-1.0.0-SNAPSHOT.jar" 
"xxx-foo--SNAPSHOT"   => NO

The generic issue is that we could have random artifact name such as xxx-foo-1.2.3.263541263412.jar or whatever else.

1. I think we should at support the default SNAPSHOT (very standard)
2. As a default, if name does not math regex, have a sane default. Maybe stop at the last - ?

@pierre Any thoughts?

[sbrossie]

This is really annoying and should be fixed: Example:

kpm install_java_plugin 'dev:xxx-foo' --from-source-file="/Somewhere/xxx-foo/target/xxx-foo-1.0.0.jar" --version="1.0.0" --destination=/var/tmp/mybundles

As a result the entry /var/tmp/mybundles/plugins/java/xxx will be created (and if multiple plugins starts with xxx, then each install overrides previous one). We would want /var/tmp/mybundles/plugins/java/xxx-foo instead.

[pierre]

Interesting that the SNAPSHOT one doesn't work, we have a test specifically for this: 576e3ff#diff-def9654044137b79bf1d315ac4671d1bR62.

[sbrossie]

Also, something that i noticed is that we need to specify the version (but we should not have to, as it can be extracted):

kpm install_java_plugin analytics --from-source-file=/SOMETHING/killbill/killbill-analytics-plugin/target/analytics-plugin-4.2.4-SNAPSHOT.jar 
no implicit conversion of nil into String
/Users/sbrossier/.rvm/rubies/ruby-2.1.1/lib/ruby/2.1.0/pathname.rb:389:in `initialize'
/Users/sbrossier/.rvm/rubies/ruby-2.1.1/lib/ruby/2.1.0/pathname.rb:389:in `new'
/Users/sbrossier/.rvm/rubies/ruby-2.1.1/lib/ruby/2.1.0/pathname.rb:389:in `join'

However, following works:

kpm install_java_plugin analytics --from-source-file=/Users/sbrossier/Src/killbill/killbill-analytics-plugin/target/analytics-plugin-4.2.4-SNAPSHOT.jar --version=4.2.4-SNAPSHOT
I, [2017-08-07T14:33:14.130954 #3374]  INFO -- : Successful installation of ...