Question to entry handler call sequence in traverse_state() about uml-state-machine-in-c

[kiishor]

Hi spachner,

Thanks for pointing it. Yes it’s a bug. I’ll fix it soon.

Thanks,
Nandkishor

[kiishor]

Hi Stefan,

After analyzing and debugging, I found that it's not a bug. The entry handler is getting called as per the order.

pTarget_State is traversed upward to its parent node in the process of finding the traverse path.
as shown below

  // Is Source hierarchy level greater than target level?
  else if(pSource_State->Level < pTarget_State->Level)
  {
    // Traverse the target state to upward,
    // Till it matches with source state hierarchy level.
    while(pSource_State->Level < pTarget_State->Level)
    {
      pTarget_Path[index++] = pTarget_State;  // Store the target node path.
      pTarget_State = pTarget_State->Parent;
    }
  }

  // Now Source & Target are at same hierarchy level.
  // Traverse the source & target state to upward, till we find their common parent.
  while(pSource_State->Parent != pTarget_State->Parent)
  {
    EXECUTE_HANDLER(pSource_State->Exit, triggered_to_self, pState_Machine);
    pSource_State = pSource_State->Parent;  // Move source state to upward state.

    pTarget_Path[index++] = pTarget_State;  // Store the target node path.
    pTarget_State = pTarget_State->Parent;    // Move the target state to upward state.
  }

pTarget_State is not the final node, it is the first node for the entry traverse.

Thanks,
Nandkishor

[spachner]

Hi Nandkishor,

great, thank's for pointing that out. I was missleaded by the variable's name pTarget_State which is actually not the target in this line. I'm am closing the ticket.

regards

spachner