Coder Social home page Coder Social logo

Comments (2)

dneto0 avatar dneto0 commented on July 18, 2024

Also affects GLSL.std.450:

          %1 = OpExtInstImport "GLSL.std.450"
          %blam  = OpExtInst %a %1 Round %2 %3 %5 %7 %8
          OpNop

The Round extended instruction in GLSL is only supposed to take one normal argument.

from spirv-tools.

dneto0 avatar dneto0 commented on July 18, 2024

I traced it to the SPIR-V core instruction grammar file: For OpExtInst, there is an argument following the LiteralExtInstInteger operand whic his IdRef with quantifier "". In the assembler and binary parser, the value of the extended instruction integer determines the expected operands, but then the IdRef-quantifier- is still on the expected-operands stack.

In other cases, e.g. OpImageFetch, the ImageOperands bit mask fully determines the operands to follow and the grammar does not include them in the ImageFetch instruction listing. It's arguable whether the same rule should apply in the case of OpExtInst. Since we've already published the grammar, and it's arguable how much checking other tools should have to do, I'm ok just patching this in the SPIRV-Tools setup phase.

from spirv-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.