The plugin is not getting all birthdays on skypeweb about pidgin-birthday-reminder

[kgraefe]

Can you get a screenshot of the info pages of a working and a non-working buddy? (You may obfuscate unrelated information.)

[TomTheDragon]

Okay, i made a screenshot of 4 info pages, the ones on the left were recognized and the ones on the right dont.

[translation]
Vorname = First name
Nachname = Surname
Geburtstag = Birthday
Geschlecht = Sex
Stadt = Town

[kgraefe]

Okay, that is not what I expected. :-) There is an ancient bug with protocols that made the date format up to the client (ICQ afair), resulting in different formats for different buddies depending on their locale. However, that might not be the case for Skype and is definitely not the cause in your case.

I'll have to build a debug version with additional debug output for you to run.

[kgraefe]

Okay, so I added some debug messages. Can you please try out the Win32 build?

Please open the debug window (Help -> Debug window) before scanning. You can easily trigger the scan for a specific buddy by opening its info window through the context menu.

[TomTheDragon]

I am guessing you need logs like this:
(i did change some little things like the buddy names)

---

(02:30:53) birthday-reminder: Scanning sven...
(02:30:53) birthday-reminder: Birthday not found. :~(

---

(02:33:51) birthday-reminder: Scanning fox...
(02:33:51) birthday-reminder: Birthday not found. :~(

---

(02:37:03) birthday-reminder: Scanning dragon...
(02:37:03) birthday-reminder: Birthday not found. :~(

---

[kgraefe]

Okay, let's try some more output (Win32).

The lines starting with "birthday_reminder" are sufficient. ;-)

[TomTheDragon]

Okay here are some more logs:

---

(06:09:51) birthday-reminder: Scanning freak...
(06:09:51) birthday-reminder: needle: Birthday
(06:09:51) birthday-reminder: hay: Vorname
(06:09:51) birthday-reminder: hay: Geburtstag
(06:09:51) birthday-reminder: hay: Geschlecht
(06:09:51) birthday-reminder: hay: Language
(06:09:51) birthday-reminder: hay: Info
(06:09:51) birthday-reminder: Birthday not found. :~(

---

(06:11:34) birthday-reminder: Scanning harren...
(06:11:34) birthday-reminder: needle: Birthday
(06:11:34) birthday-reminder: hay: Vorname
(06:11:34) birthday-reminder: hay: Geburtstag
(06:11:34) birthday-reminder: hay: Geschlecht
(06:11:34) birthday-reminder: hay: Language
(06:11:34) birthday-reminder: hay: Land
(06:11:34) birthday-reminder: hay: Province
(06:11:34) birthday-reminder: hay: Homepage
(06:11:34) birthday-reminder: hay: Info
(06:11:34) birthday-reminder: Birthday not found. :~(

---

(06:13:07) birthday-reminder: Scanning samson...
(06:13:07) birthday-reminder: needle: Birthday
(06:13:07) birthday-reminder: hay: Vorname
(06:13:07) birthday-reminder: hay: Geburtstag
(06:13:07) birthday-reminder: hay: Language
(06:13:07) birthday-reminder: hay: Land
(06:13:07) birthday-reminder: Birthday not found. :~(

---

(06:13:50) birthday-reminder: Scanning mecha...
(06:13:50) birthday-reminder: needle: Birthday
(06:13:50) birthday-reminder: hay: Vorname
(06:13:50) birthday-reminder: hay: Geburtstag
(06:13:50) birthday-reminder: hay: Geschlecht
(06:13:50) birthday-reminder: hay: Language
(06:13:50) birthday-reminder: hay: Land
(06:13:50) birthday-reminder: hay: Province
(06:13:50) birthday-reminder: hay: Stadt
(06:13:50) birthday-reminder: hay: Info
(06:13:50) birthday-reminder: Birthday not found. :~(

---

The first two are from german and the other two from american users.

[kgraefe]

Can you do this for a working skypeweb account, too?

What is the skypeweb version you are using?

[TomTheDragon]

Sure i can and.. it did not work with the ones it did work before, looks like they changed something on the plugin or so :/
I am using the 1.1 release. (07.01.16)

[kgraefe]

Okay, apparently the skypeweb does not ship its own translation and I wonder, how it could work for some of your contacts in the first place, hm. I could not find out for certain, but I'd guess the plugin is just using the translations shipped with Pidgin.

Please try this commit (Win32). It basically matches against the strings "Birthday" and its translation that is shipped with Pidgin. That way the birthday reminder should not break even if skypeweb starts to ship its own translations (as long as they match Pidgin's translation for this particular string).

[TomTheDragon]

I tested it and my CPU did go up to 100% for over 15 minutes until i killed Pidgin.
But it did seem to work fine after a restart and he did get really every birthday date :)
But only if you show that info page on every of your buddies and it can be a little stressful if you have some hundreds of skype buddies in your list ;)

[kgraefe]

That is because:

• The plugin waits two minutes between two automatic scans because some protocols did not like it, when it scanned all at once.
• Your buddies have already been scanned and will not be scanned again automatically. Due to this bug they did not have a birthday attached, though.

Thank you very much for your help.

[TomTheDragon]

Hm its just an idea but.. how about different waiting times for different protocols then? I know that ICQ for example is really picky about its limits but skypeweb seems to have a really big limits for scanning of profile infos.

[kgraefe]

That requires a major rewrite of the scan algorithm. Currently the plugin cycles through all contacts globally. To implement this, one cycle loop per supported protocol would be needed.

[TomTheDragon]

Well.. it was just a idea to make the scanning a little bit quicker, since the standard method can take quite a while.