Coder Social home page Coder Social logo

Simplify Style API about crouton HOT 7 CLOSED

keyboardsurfer avatar keyboardsurfer commented on July 26, 2024
Simplify Style API

from crouton.

Comments (7)

gabrielittner avatar gabrielittner commented on July 26, 2024

I agree with you.

from crouton.

pommedeterresautee avatar pommedeterresautee commented on July 26, 2024

My 2 cents...

1/ there is already a way to use a custom view (Crouton.make(Activity, CustomView) )
2/ The Style class make it super easy to create a custom view. Moreover, only useful function are implemented (color, animation ...).

So it has a real meaning to let it as it is and no real drawback...

from crouton.

pboos avatar pboos commented on July 26, 2024

This is more or less done in #86 .

I do agree that duration and animations should be outside Style. But background color and text color should stay in Style.

from crouton.

chrisjenx avatar chrisjenx commented on July 26, 2024

Yeah Im going to redo the pull request with animations in the configuration too. Anything else just raise it on the new pull request.

from crouton.

chrisjenx avatar chrisjenx commented on July 26, 2024

Re done the pull-request #94 added animation into the config too.

I guess for the simplicity of the lib, I think @keyboardsurfer should decide when to stop with the base implementation, and tell people to use custom views. Hopefully this separation will now make custom views an option.

from crouton.

keyboardsurfer avatar keyboardsurfer commented on July 26, 2024

The changes in #94 have been released with version 1.8. It's true, that Style has been growing quite a lot since it's introduction. Having a non view Configuration is a good start to stop the Style's growth. Also a custom View Crouton can hold quite a lot of the Style's attributes.

from crouton.

keyboardsurfer avatar keyboardsurfer commented on July 26, 2024

#86

from crouton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.