Comments (7)
I agree with you.
from crouton.
My 2 cents...
1/ there is already a way to use a custom view (Crouton.make(Activity, CustomView) )
2/ The Style class make it super easy to create a custom view. Moreover, only useful function are implemented (color, animation ...).
So it has a real meaning to let it as it is and no real drawback...
from crouton.
This is more or less done in #86 .
I do agree that duration and animations should be outside Style. But background color and text color should stay in Style.
from crouton.
Yeah Im going to redo the pull request with animations in the configuration too. Anything else just raise it on the new pull request.
from crouton.
Re done the pull-request #94 added animation into the config too.
I guess for the simplicity of the lib, I think @keyboardsurfer should decide when to stop with the base implementation, and tell people to use custom views. Hopefully this separation will now make custom views an option.
from crouton.
The changes in #94 have been released with version 1.8. It's true, that Style has been growing quite a lot since it's introduction. Having a non view Configuration is a good start to stop the Style's growth. Also a custom View Crouton can hold quite a lot of the Style's attributes.
from crouton.
from crouton.
Related Issues (20)
- Where can I find the latest jar?
- Not able to use a white background HOT 4
- Show at bottom HOT 1
- Push view down with crouton HOT 1
- Cant use a custom Style for Crouton
- Memory leak in DefaultAnimationsBuilder HOT 3
- memory leak in DefaultAnimationsBuilder.java HOT 5
- not an issue :) but a question about Snackbar. HOT 2
- Croupton not works on android version 16 HOT 2
- Crouton with custom view and match_parent height HOT 2
- No constructors works HOT 1
- How to use in Fragment? HOT 1
- change position HOT 3
- Visual glitch when using a navigation drawer HOT 2
- show crouton below Toolbar HOT 1
- not working... after changing app theme.
- SpannableString or Html tags ? HOT 2
- Crouton disable auto hide HOT 1
- Crouton Not work when app come background nearly after 2 mins HOT 2
- How to use Crouton.makeText in AsyncTask
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crouton.