Comments (4)
This is most likely a problem with your fetching logic. And since you did not provide a repro, I'm just going to close this.
from material-react-table.
@KevinVandy I cannot reproduce it because MRT doesnt seem to work in Stackblitz or Codesandbox:
- https://codesandbox.io/p/devbox/github/KevinVandy/material-react-table/tree/v2/apps/material-react-table-docs/examples/remote/sandbox?file=%2Fsrc%2Fmain.tsx%3A10%2C1
- https://stackblitz.com/github/KevinVandy/material-react-table/tree/v2/apps/material-react-table-docs/examples/remote/sandbox?file=src%2FTS.tsx
PS: I am 100% positive it is not coming from my implementation, it only does that with min/max. It is basically adding the filter for min/max with undefined values:
[ { "id": "adjustedPrice", "value": [ undefined, undefined ] }, { "id": "recommendedPrice", "value": [ undefined, undefined ] }, { "id": "currentPrice", "value": [ undefined, undefined ] }, { "id": "brand", "value": [ "ACTION" ] } ]
If the filter value is empty for both min and max, it should be removed from the filter state, right ?
from material-react-table.
@jerlam06 It works perfectly fine. You'll just have to mock your own API returns in a sandbox. To make a reproduction, you just have to prove that some state is causing a re-render of some other unrelated state that it is not supposed to.
![image](https://private-user-images.githubusercontent.com/28243511/310216941-769fed42-582a-4684-a440-3d09f4e63dad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTI2NzQ2NDksIm5iZiI6MTcxMjY3NDM0OSwicGF0aCI6Ii8yODI0MzUxMS8zMTAyMTY5NDEtNzY5ZmVkNDItNTgyYS00Njg0LWE0NDAtM2QwOWY0ZTYzZGFkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA0MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNDA5VDE0NTIyOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZkODI2MmM3NjM5MzBkZDNhOTcxMTkzNWJjN2QxZjc5MjdhN2ZiYzU1MGNhNjgxYzJiMDI0MzVkZmQzMTY4OWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.GxtzSIUQ-Vj2KsVHtHuUreCnLI_zfMuOULeVWqfsAbQ)
from material-react-table.
@KevinVandy Ok thanks. I could reproduce it there => https://stackblitz.com/edit/github-8arb9x?file=src%2FTS.tsx
Open the dev console and trigger show/hide filters, show filters triggers a filter state change for no reason. Plus, the min/max filters remain in the filter state even when empty, this is not consistent I believe.
Thanks in advance, and very good job with the v2, it is amazing :)
from material-react-table.
Related Issues (20)
- Really strange issue HOT 7
- Localisation of filters does not apply to the filter menu HOT 1
- "Show filter" triggers onColumnFiltersChange for backend pagination
- Mantine Filter Search Does Not Work Correctly and Highlight Words When Turkish Characters Are Used with Capslock On. HOT 2
- Virtualization is not working properly even on the documentation page! HOT 5
- Sticky Pinned Columns Misplacement in Material React Table for RTL Language
- MRT_TablePaper zIndex is lower than Appbar in Fullscreen
- Pinned columns collapsing even with layoutMode: 'grid-no-grow'
- Drag row exception when row virtualization is true HOT 1
- Header title has been dissapear from v10 to v11 HOT 1
- Pagination Container Box gets cut off when default font size is not 16px HOT 1
- [BUG] - Sub Row Selection not working correctly
- Mui palette theme problem HOT 1
- react-query/sandbox does not work properly in codesandbox.io
- Tooltip on FullScreenButton not showing on focus HOT 1
- Getting Error while loading TS.tsx HOT 2
- onSortingChange getting called twice on first render HOT 3
- positionCreatingRow is been ignored HOT 1
- Data does not refresh when using editDisplayMode: 'table' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-react-table.