Comments (3)
Thanks @angelcustodio! :D
Imagine you want to color the progress differently while it changes from a value to another to give some visual information in addition of the percentage.
Yeah, I'm not intending to remove that functionality! The intent is rather to shift the logic from being a classForPercentage
function to using className
directly. For instance, if you were using classForPercentage
like this before:
function getClassForPercentage(percentage) {
if (percentage < 50) {
return 'some-class';
}
return 'some-other-class';
}
<CircularProgressbar percentage={someValue} classForPercentage={getClassForPercentage} />
...you could rewrite it as this:
function getClassForPercentage(percentage) {
if (percentage < 50) {
return 'some-class';
}
return 'some-other-class';
}
<CircularProgressbar percentage={someValue} className={getClassForPercentage(someValue)} />
You don't have to change much, and it seems conceptually easier to grok (from feedback from jedwards1211 in #24). Does this address your concern?
The percentage should be optional also having the possibility to pass an element as a children to render it there.
I don't quite follow what you mean exactly - could you give me an example?
from react-circular-progressbar.
I think classForPercentage
is very useful for styling purposes.
Imagine you want to color the progress differently while it changes from a value to another to give some visual information in addition of the percentage.
PS: The percentage should be optional also having the possibility to pass an element as a children to render it there. Cool, huh? :)
PS2: Great job :D
from react-circular-progressbar.
Released in version 1.0.0.
from react-circular-progressbar.
Related Issues (20)
- Upgrade to React 18? HOT 4
- Can this be embedded into a Button? HOT 1
- Help HOT 1
- Doesn't work with react 18 above HOT 4
- have a fill animation from 0 to value for first render . HOT 1
- Unable to add image from local project to CircularProgressbar
- Handle to Manually change progress rather than programatically
- Going past 100%
- Transition not working after value>=80
- Custom sitemap file name. HOT 1
- Unable to add gradient to the trail color. HOT 1
- peer dependencies
- TypeError: Object prototype may only be an Object or null: undefined HOT 3
- How to set the path and trailcolor in form of variables name HOT 1
- Progress bar out of bounds and cut off on Safari
- Need a provision to show the color of the track around the filled path HOT 1
- [bug] :when i am importing the file it is showing in import error in next js
- circle animation is still not working
- Refine type of the `classes` prop HOT 1
- AnimatedProgressProvider is outdated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-circular-progressbar.