Coder Social home page Coder Social logo

Comments (3)

kevinsqi avatar kevinsqi commented on August 16, 2024 1

Thanks @angelcustodio! :D

Imagine you want to color the progress differently while it changes from a value to another to give some visual information in addition of the percentage.

Yeah, I'm not intending to remove that functionality! The intent is rather to shift the logic from being a classForPercentage function to using className directly. For instance, if you were using classForPercentage like this before:

function getClassForPercentage(percentage) {
  if (percentage < 50) {
    return 'some-class';
  }
  return 'some-other-class';
}

<CircularProgressbar percentage={someValue} classForPercentage={getClassForPercentage} />

...you could rewrite it as this:

function getClassForPercentage(percentage) {
  if (percentage < 50) {
    return 'some-class';
  }
  return 'some-other-class';
}

<CircularProgressbar percentage={someValue} className={getClassForPercentage(someValue)} />

You don't have to change much, and it seems conceptually easier to grok (from feedback from jedwards1211 in #24). Does this address your concern?

The percentage should be optional also having the possibility to pass an element as a children to render it there.

I don't quite follow what you mean exactly - could you give me an example?

from react-circular-progressbar.

angelcustodio avatar angelcustodio commented on August 16, 2024

I think classForPercentage is very useful for styling purposes.
Imagine you want to color the progress differently while it changes from a value to another to give some visual information in addition of the percentage.

PS: The percentage should be optional also having the possibility to pass an element as a children to render it there. Cool, huh? :)

PS2: Great job :D

from react-circular-progressbar.

kevinsqi avatar kevinsqi commented on August 16, 2024

Released in version 1.0.0.

from react-circular-progressbar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.