bug when importing saved data from Tab Groups addon about conex

[kesselborn]

Mmm @dotmarco: happy to re-open if I can get a test file for recreating the problem — I would actually really appreciate that. Feel free to replace all urls with „http://example.com“ for privacy reasons.
@grahamperrin you have a 19mb backup json file? How many open tabs do you have? 40000? ;)
@both: if you open the browser logs, perhaps you see some exceptions in options_ui.js or background.js?

[sascha224]

Importing from Tab Groups doesn't work at all for me. After selecting the backup file and importing, nothing changes in containers or Conex. One time, it only created empty containers with correct names of Tab Groups, but without any tabs in it. Not reproducible.

[kesselborn]

76 groups ... that's a hell of a config file!

[kesselborn]

@grahamperrin don't think that it makes a difference. Please always rather re-open an issue over-eagerly than just commenting, makes it easier for me to find it ;) ... I don't care if I have to close it again (makes me feel super-productive actually ;) )

[smichel17]

@kesselborn I think if you close it, the creator cannot re- open

[kesselborn]

really? do you have an example file for me? It works correctly with my sample files.

Thanks

[kesselborn]

So: it never worked or did it not work one time but the next time it did? I would need a test file for this to test as it works with my backups ... as this is not a core feature,I don’t plan to invest time unless I have a backup example which fails.
Cheers
Daniel

[sascha224]

Here is mine:
(deleted)

[grahamperrin]

I, too, experimented a while ago and found no apparent response after selecting the file. I assumed that the feature was not yet implemented.

(For me: just a curiosity. I have no real need to use containers in lieu of groups.)

At first, I wondered about the 25-character limit. That seems to be a limit in Mozilla's extension, not in Firefox (55.0.3).

[kesselborn]

@sascha224 @michel-bosseaux @grahamperrin @dotmarco please test again with >= v0.0.49

[sascha224]

Now it works for me - thank you!

[grahamperrin]

Not working for me (sorry) with:

• Conex 0.0.51
• Firefox Developer Edition 57.0b3 (64-bit)
• pre-release build 17B25c of Mac OS X 10.13
• a ~19 MB file, tabGroups-manual-20170930-061951.json

As before,

just a curiosity.

– for my use case, I shouldn't request reopening of this issue.

[dotmacro]

Thanks for the quick update, @kesselborn

Still not working for me. After selecting the backup tabGroups-manual file, there's no indication the file is being imported, and nothing changes in Conex, containers, or tabs.

Tested both Conex 0.0.49 and Conex 0.0.53. Tried with 0 tabs open, and with all (~100) of my old tabs open. Using Firefox 57.0b5.

Don't re-open for me (manually sorted my tabs), but I'm happy to help test if you do. :)

[grahamperrin]

Today's tabGroups-manual-20171005-214857.json is 8.8 MiB, 970 tabs, around seventy-six groups.

TypeError: extData is null
Stack trace:
reader.onload@moz-extension://dc96ed6d-1282-4086-8e86-aab271e8136d/conex-options_ui.js:32:49

[grahamperrin]

TypeError: tab.extData is undefined
Stack trace:
reader.onload@moz-extension://dc96ed6d-1282-4086-8e86-aab271e8136d/conex-options_ui.js:30:1

[grahamperrin]

Sorry, I forgot to mention: those two most recently reported errors are presented with Conex with Firefox 56. Does that make a difference?

[kesselborn]

Oh, ok ... didn’t know

…

Am 08.10.2017 um 06:17 schrieb smichel17 ***@***.***>: @kesselborn I think if you close it, the creator cannot re- open — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[grahamperrin]

Following b46d794 I tested Conext 0.0.63 with a Firefox 56.0 profile with a locally-held file (10.9 MiB):

• tabGroups-manual-20171008-065923.json

– success. Imports became possible.

tl;dr

Three test sessions, a well-specified notebook with 16 GB real memory and 8 GB available for swap:

• all three resulted in addition of containers
• the first ended with a crash of Firefox, probably attributable more to Mozilla code than to Conex
• I chose to kill the second after maybe an hour or so
• I prepared for a trouble-free third session by adding boolean browser.tabs.remote.force-disable – true – before the launch of Firefox.

Whether the same approach (disabling multiprocess (e10s)) to avoiding trouble with so many tabs is possible with Firefox 57, I don't know.

A minor spin-off from the test sessions:

• import from Tab Groups (Quicksaver - Luís Miguel): do not create a container for any window that had no group · Issue #64 · kesselborn/conex

The opening post here

… wrong groups …

Yes, as far as I recall I found numerous things wrongly contained in at least two of today's test sessions but I reckon, don't reopen this issue. Instead:

• leakage with Conex: non-contained unloaded tabs are subsequently loaded into a container · Issue #58 · kesselborn/conex

– whilst there's nothing import-related in the opening post there, I'm reasonably certain that we have the same underlying bug(s).

(We might work towards a more descriptive title for #58 … for now, maybe we can just think of it as an umbrella for leakage-related symptoms.)

[grahamperrin]

… I prepared for a trouble-free third session by adding boolean browser.tabs.remote.force-disable – true – before the launch of Firefox. …

Maybe related: Mozilla bug 1037179 - Loading many (30–60) tabs simultaneously takes almost 2x longer with e10s

[kesselborn]

Ah, that’s a good one: I think I can create tabs for with state disabled ... will try that one out

…

Am 10.10.2017 um 06:49 schrieb Graham Perrin ***@***.***>: … I prepared for a trouble-free third session by adding boolean browser.tabs.remote.force-disable – true – before the launch of Firefox. … Maybe related: Mozilla bug 1037179 - Loading many (30–60) tabs simultaneously takes almost 2x longer with e10s — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.