Coder Social home page Coder Social logo

Comments (4)

garazdawi avatar garazdawi commented on May 27, 2024 2

eluklar is indeed me. I think github actions failed for 25.3.2.9 so I had to build the pre-built source manually which is why it shows up like that.

from kerl.

paulo-ferraz-oliveira avatar paulo-ferraz-oliveira commented on May 27, 2024

👋 @vassilevsky.

I'm not sure how kerl is involved in this, but maybe I'm missing a detail here.

Note: eluklar is potentially @garazdawi, and he might have a better explanation than me as to why the packaging was so.

In any case, kerl can build 25.3.2.9, as per this repo's CI.

What would you suggest we do? Or what is the exact issue we should look at?

from kerl.

vassilevsky avatar vassilevsky commented on May 27, 2024

Nice to meet you, Paulo :)

For now I have solved this issue by pointing Kerl to my fork of OTP. My fork does not have releases, so Kerl resorts to downloading tags. In the archives made by GitHub, files are owned by root:

$ tar -tvf otp-OTP-25.3.2.9.tar | head -n 3
drwxrwxr-x  0 root   root        0 Feb  7 18:01 otp-OTP-25.3.2.9/
drwxrwxr-x  0 root   root        0 Feb  7 18:01 otp-OTP-25.3.2.9/.devcontainer/
-rw-rw-r--  0 root   root     1188 Feb  7 18:01 otp-OTP-25.3.2.9/.devcontainer/devcontainer.json

$ tar -tv --numeric-owner -f otp-OTP-25.3.2.9.tar | head -n 3
drwxrwxr-x  0 0      0           0 Feb  7 18:01 otp-OTP-25.3.2.9/
drwxrwxr-x  0 0      0           0 Feb  7 18:01 otp-OTP-25.3.2.9/.devcontainer/
-rw-rw-r--  0 0      0        1188 Feb  7 18:01 otp-OTP-25.3.2.9/.devcontainer/devcontainer.json

They are extracted without problems and the build succeeds :)

Very nice to meet you, Lukas :) Thank you for making this effort of uploading OTP archives to GitHub releases. I found your issue #351 where you announced it and it led me to this discovery. I did not want to bother you at all with this, but oh well.

I think that one possible thing that Kerl might do to prevent errors like this in the future is to always run tar --no-same-owner --no-same-permissions. This is the default for non-root users, and it could very well be enabled for root user as well. I see no reason to preserve ownership when extracting any OTP archive, regardless of its source. File ownership inside the archive should not matter. I could make this change myself and send you a pull request, if you agree.

Or we might as well do nothing, because this is such a niche problem, and next OTP archives will most likely be made by CI anyway :)

from kerl.

paulo-ferraz-oliveira avatar paulo-ferraz-oliveira commented on May 27, 2024

File ownership inside the archive should not matter. I could make this change myself and send you a pull request, if you agree

I think it's a reasonable change. Just be sure to make it POSIX compliant, since kerl is usable under Linux and macOS, at least. CI should be enough to test it, but one never knows.

from kerl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.