Coder Social home page Coder Social logo

Comments (5)

mattdangerw avatar mattdangerw commented on May 18, 2024

Thanks for bringing this up! This is helpful!

I am unsure of how we could monitor for usage of the TFA utilities, but can poke around. That could help us prioritize well here.

Re CRF, did you have a design in mind?

I think the highest priority symbol of the bunch might be the skip_gram* functions. We have these in TFA, and another similar version in keras.preprocessing. This would be better off as a preprocessing layer that could replace both of those usages. word2vec is definitely a common used model we would like to enable easy support for with this library.

I think a skip gram preprocessing layer, with the goal of replacing the tf.keras.preprocessing.sequence.skipgrams usage in the official tensorflow word2vec tutorial, is a good goal.

from keras-nlp.

bhack avatar bhack commented on May 18, 2024

I am unsure of how we could monitor for usage of the TFA utilities, but can poke around. That could help us prioritize well here.

We have a quite old and long thread about this at:
tensorflow/addons#236

Re CRF, did you have a design in mind?

I think that @howl-anderson, our new CRF codeowner, could give use some feedback.

I think the highest priority symbol of the bunch might be the skip_gram* functions. We have these in TFA, and another similar version in keras.preprocessing. This would be better off as a preprocessing layer that could replace both of those usages.

This has an (old) custom op in TFA so I hope that you can handle it here with a pure compositional python/TF solution.

We have also an rnn and a seq2seq namespace that you could evaluate in this context:
https://www.tensorflow.org/addons/api_docs/python/tfa/rnn
https://www.tensorflow.org/addons/api_docs/python/tfa/seq2seq

/cc @seanpmorgan @yarri-oss @theadactyl

from keras-nlp.

Stealth-py avatar Stealth-py commented on May 18, 2024

Hey @mattdangerw! I wanted to ask if the keras team is still interested in implementing a preprocessing layer for models such as the skipgram model.

from keras-nlp.

bhack avatar bhack commented on May 18, 2024

/cc @seanpmorgan @yarri-oss

from keras-nlp.

bhack avatar bhack commented on May 18, 2024

keras-team/keras-cv#74 (comment)

from keras-nlp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.