Comments (7)
Confirmed. I tried to use it in an Android Application and I always get an exception.
from qrgen.
In my branch (https://github.com/atomfrede/QRGen/tree/modularize) I've split the library into three modules core
, javase
and android
(so what do you think about that solution...)
core
contains all stuff that can be used with android and standard java. javase
is more or less the current state and android
replaces all operations using a BufferedImage
with android's Bitmap
.
Nevertheless there are some minor drawbacks:
- Not sure how an android library behaves when some transitive dependency has been build for java 7 (Android Supports java 7 since KitKat)
- Robolectrics unit testing capabilties regarding
Bitmap
s are not optimal. I think they use a shadow for allBitmap
related stuff, therefore theFile
generated is broken and empty. But I've tested the implementation on a real emulator an the QRCodes are generated fine.
from qrgen.
Great work here as well @atomfrede . Perhaps I can get this as part of the next release. If not we should be able to solve this soon. I really want users of QRGen to be able to use ZXING as is, but at the same time get some convenience from QRGen. If we can solve the use case in a pretty way, then this will definately be a refactor I want to push :)
from qrgen.
Maybe a longer pre-release phase would be a good idea to test the android module extensive on different api levels. Would like to me to file a pull request or should I merge my work into master first? What about creating a development branch so that master is always ready to release even when larger refactorings happen (on dev branch)?
from qrgen.
I think the current setup works good, so I am hesitant to change it. Additionally, I don't want the overhead of having to configure and manage CI setup for two branches.
Could you update the Readme with a section for javase and one for android before making a PR.
Does this refactor cause breaking changes to existing users? If so the version should be bumped to 2.0-SNAPSHOT before PR as well.
from qrgen.
It will break something as current users have to change their pom
(or gradle
or whatever) as the location of the artifact has changed. Nevertheless the api is the same so there is no need to change the code (expect imports). Will prepare everything during the day and then file a PR.
from qrgen.
#17 fixes this. This fix is available in 2.0-SNAPSHOT. Will release 2.0 soon, after it has marinated in the intertubes a bit :)
from qrgen.
Related Issues (20)
- Incorrect checksum for v2.6.0 HOT 7
- Does it support iso 18004 HOT 1
- Java Bitmap not found in QRGen HOT 1
- Qr
- For latest gradle versions, to make it work
- Upgrade Batik to 1.14 for security
- How can I program QR codes to do certain things? HOT 1
- QR Code Geberator HOT 1
- Next release plans HOT 4
- Customization with rounded square
- Cannot compile Project HOT 1
- Could not find com.github.kenglxn.QRGen:javase:3.0.0. HOT 5
- com.google.zxing.NotFoundException in decode
- Support for WPA3's R:1
- Custom shapes support HOT 2
- mavenCentral() availability ? HOT 4
- Set image dpi
- Could not find com.github.kenglxn.QRGen:android:2.2.0. HOT 1
- Jitpack.io Checksum validation failed for 2.6.0 HOT 2
- All old versions are gone (2.6.0 ; 2.5.0 ; 2.4.0 ; 2.3.0 ; 2.2.0 ...) HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from qrgen.