Coder Social home page Coder Social logo

Comments (10)

AndreSteenbergen avatar AndreSteenbergen commented on September 26, 2024 1

I will try and make a PR

from flashcap.

AndreSteenbergen avatar AndreSteenbergen commented on September 26, 2024 1

H.264 is not frame by frame, so it shoudl retun null. That is good behaviour. Stopping at the first non supported pixelformat is

from flashcap.

AndreSteenbergen avatar AndreSteenbergen commented on September 26, 2024 1

No problem. I ran into trouble with the Logitech C920. You can also add that camera to the supported camera's now ;)

from flashcap.

AndreSteenbergen avatar AndreSteenbergen commented on September 26, 2024

This is my fix:
image

from flashcap.

AndreSteenbergen avatar AndreSteenbergen commented on September 26, 2024

I added the PR, but can't seem to link it ...

from flashcap.

kekyo avatar kekyo commented on September 26, 2024

Thanks for the PR! It looks like you removed IsKnownPixelFormat(). This method exists to check if the FlashCap is in a format that will be processed correctly as independent frame data.

Assuming your camera returns H.264, is this returned as frame-by-frame independent data? If so, what does the resulting data format actually look like?
I am not familiar with H.264, but I thought H.264 format was continuous (not separated between frames) data, so I thought it should not be included in IsKnownPixelFormat().

I'd be interested to see what the format would look like if I actually made this modification and referenced BufferScope.Buffer. Does it say the camera is H.264 but returns it as JPEG or something?

    // What a binary format for `image`?
    byte[] image = bufferScope.Buffer.ExtractImage();

from flashcap.

AndreSteenbergen avatar AndreSteenbergen commented on September 26, 2024

No I didn't remove it. I replaced the code outside the loop

.Where(x => IsKnownPixelFormat(x))

from flashcap.

AndreSteenbergen avatar AndreSteenbergen commented on September 26, 2024

The enumerator stops at the first signs of null. Not trying the next value anymore.

from flashcap.

kekyo avatar kekyo commented on September 26, 2024

Ouch, I understand it! I will check my environment, thank you explanation.

from flashcap.

kekyo avatar kekyo commented on September 26, 2024

Merged, thank you again!

from flashcap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.